You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jl...@apache.org on 2026/09/09 18:39:41 UTC

(superset) branch master updated: fix(reports): don't send both chart and dashboard on create (#43137)

This is an automated email from the ASF dual-hosted git repository.

sadpandajoe pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 67d170e6119 fix(reports): don't send both chart and dashboard on create (#43137)
67d170e6119 is described below

commit 67d170e61198954122b1e93cf380ca4a8f1855fe
Author: Joe Li <jo...@preset.io>
AuthorDate: Wed Sep 9 11:39:34 2026 -0700

    fix(reports): don't send both chart and dashboard on create (#43137)
    
    Co-authored-by: Claude Opus 4.8 <no...@anthropic.com>
---
 superset-frontend/src/features/reports/ReportModal/index.tsx | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/superset-frontend/src/features/reports/ReportModal/index.tsx b/superset-frontend/src/features/reports/ReportModal/index.tsx
index 13108b92e48..56a7cde0799 100644
--- a/superset-frontend/src/features/reports/ReportModal/index.tsx
+++ b/superset-frontend/src/features/reports/ReportModal/index.tsx
@@ -195,6 +195,10 @@ function ReportModal({
       active: true,
       force_screenshot: false,
       custom_width: currentReport.custom_width,
+      // A report belongs to either a chart or a dashboard, never both. Explore can
+      // carry dashboard context even for a chart-scoped report, so send only the
+      // entity that matches the creation method; a payload with both `chart` and
+      // `dashboard` is rejected by the backend with a 422 error.
       ...(creationMethod === CreationMethod.Charts
         ? { chart: chart?.id }
         : { dashboard: dashboardId }),