You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/05/08 13:14:17 UTC
[GitHub] [shardingsphere] ThanoshanMV opened a new pull request #10286: Fix rule definition in Oracle `ALTER DATABASE`'s `defaultSettingsClauses`
ThanoshanMV opened a new pull request #10286:
URL: https://github.com/apache/shardingsphere/pull/10286
Relates #10136
Hi @tristaZero, @Liangda-w. I changed the `defaultSettingsClauses`'s definition, please check it.
Changes proposed in this pull request:
- In the [defaultSettingsClauses](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ALTER-DATABASE.html#GUID-8069872F-E680-4511-ADD8-A4E30AF67986) of `ALTER DATABASE` Oracle statement, I added `DOT_`
- I added `TIME_ZONE` in OracleKeyword.g4 file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ThanoshanMV commented on pull request #10286: Fix rule definition in Oracle `ALTER DATABASE`'s `defaultSettingsClauses`
Posted by GitBox <gi...@apache.org>.
ThanoshanMV commented on pull request #10286:
URL: https://github.com/apache/shardingsphere/pull/10286#issuecomment-835373838
`defaultSettingsClauses`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on pull request #10286: Fix rule definition in Oracle `ALTER DATABASE`'s `defaultSettingsClauses`
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on pull request #10286:
URL: https://github.com/apache/shardingsphere/pull/10286#issuecomment-835406138
Yes, looks good 👍 thanks for fixing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #10286: Fix rule definition in Oracle `ALTER DATABASE`'s `defaultSettingsClauses`
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #10286:
URL: https://github.com/apache/shardingsphere/pull/10286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #10286: Fix rule definition in Oracle `ALTER DATABASE`'s `defaultSettingsClauses`
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10286:
URL: https://github.com/apache/shardingsphere/pull/10286#issuecomment-835371247
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10286?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10286](https://codecov.io/gh/apache/shardingsphere/pull/10286?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bf10638) into [master](https://codecov.io/gh/apache/shardingsphere/commit/f08b09816901de8ea82f789b15328f5849db12c7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f08b098) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere/pull/10286?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #10286 +/- ##
=========================================
Coverage 67.94% 67.94%
Complexity 683 683
=========================================
Files 1706 1706
Lines 29292 29292
Branches 5270 5270
=========================================
Hits 19901 19901
Misses 7848 7848
Partials 1543 1543
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10286?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/10286?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f08b098...bf10638](https://codecov.io/gh/apache/shardingsphere/pull/10286?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org