You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/21 12:50:40 UTC

[GitHub] [airflow] turbaszek opened a new pull request #10445: Building backport packages generates README files

turbaszek opened a new pull request #10445:
URL: https://github.com/apache/airflow/pull/10445


   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek merged pull request #10445: Building backport packages generates README files

Posted by GitBox <gi...@apache.org>.
turbaszek merged pull request #10445:
URL: https://github.com/apache/airflow/pull/10445


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #10445: Building backport packages generates README files

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10445:
URL: https://github.com/apache/airflow/pull/10445#issuecomment-678611241


   > @potiuk can this be related to some changes in CI? The ses hook was merged and is available on master
   
   @turbaszek -> This will be partially fixed (no such problems should occur) in #10472 but I started discussion about it in #10471 where I discuss where it came from and whether current approach is good or whether we should implement yet another workaround until we have GitHub API that might enable that "nicely".
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #10445: Building backport packages generates README files

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10445:
URL: https://github.com/apache/airflow/pull/10445#issuecomment-678437459


   Interesting - I will take a look if this was not some teething problem. There is a potential problem I was anticipating might happen - which could have similar behaviour. Luckily we have now full audit - I can simply download the image and check everything :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] turbaszek commented on pull request #10445: Building backport packages generates README files

Posted by GitBox <gi...@apache.org>.
turbaszek commented on pull request #10445:
URL: https://github.com/apache/airflow/pull/10445#issuecomment-678295574


   Not sure what's wrong here but the errors are definitely unrelated:
   ```
   mypy: can't read file 'airflow/providers/amazon/aws/hooks/ses.py': No such file or directory
   120
   
   121
   Run pylint.......................................................................................................................Skipped
   122
   Run flake8........................................................................................................................Failed
   123
   - hook id: flake8
   124
   - exit code: 1
   125
   
   126
   tests/providers/amazon/aws/hooks/test_ses.py:0:1: E902 FileNotFoundError: [Errno 2] No such file or directory: 'tests/providers/amazon/aws/hooks/test_ses.py'
   127
   airflow/providers/amazon/aws/hooks/ses.py:0:1: E902 FileNotFoundError: [Errno 2] No such file or directory: 'airflow/providers/amazon/aws/hooks/ses.py'
   128
   tests/providers/microsoft/azure/hooks/test_base_azure.py:0:1: E902 FileNotFoundError: [Errno 2] No such file or directory: 'tests/providers/microsoft/azure/hooks/test_base_azure.py'
   129
   airflow/providers/microsoft/azure/hooks/base_azure.py:0:1: E902 FileNotFoundError: [Errno 2] No such file or directory: 'airflow/providers/microsoft/azure/hooks/base_azure.py'
   ```
   @potiuk can this be related to some changes in CI? The ses hook was merged and is available on master


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org