[GitHub] [iceberg] rymurr commented on a change in pull request #2655: [Python] add to_byte_buffer to literal classes

[GitBox <gi...@apache.org>]

rymurr commented on a change in pull request #2655:
URL: https://github.com/apache/iceberg/pull/2655#discussion_r642993965



##########
File path: python/iceberg/api/expressions/literals.py
##########
@@ -243,6 +260,9 @@ def to(self, type_var):
                                       .quantize(Decimal("." + "".join(["0" for i in range(1, type_var.scale)]) + "1"),
                                                 rounding=ROUND_HALF_UP))
 
+    def type_id(self):

Review comment:
       I wonder if it would be cleaner to add the `type_id` as a `__init__` param in `BaseLiteral`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org