You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by TILL TOENSHOFF <to...@me.com> on 2013/12/06 03:54:53 UTC

Re: Review Request 16016: upgraded glog to a libc++ compatible patched 0.3.3 (R139 + libc++ patch)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16016/
-----------------------------------------------------------

(Updated Dec. 6, 2013, 2:54 a.m.)


Review request for mesos and Niklas Nielsen.


Changes
-------

filled in some missing data (branch, jira id, tests)


Bugs: https://issues.apache.org/jira/browse/MESOS-860
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-860


Repository: mesos-git


Description (updated)
-------

Got latest revision from google-glog SVN repository:
> svn checkout http://google-glog.googlecode.com/svn/trunk/google-glog-read-only 
Checked out revision 139.  

Check issue #121 on google-glog:https://code.google.com/p/google-glog/issues/detail?id=121&q=libc%2B%2B

Downloaded libc++.diff (737 bytes): https://code.google.com/p/google-glog/issues/attachmentText?id=121&aid=1210003000&name=libc%2B%2B.diff  

Applied libc++.diff on the glog root folder.
>  patch -p0 <libc++.diff

All of the above has been packaged into glog-0.3.3-R139-libc++.tar.gz, versions.am and setup.py.in have been updated accordingly.


Diffs
-----

  3rdparty/libprocess/3rdparty/glog-0.3.3-R139-libc++.tar.gz PRE-CREATION 
  3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz 92fa52d296fea2884bd58d6010b0f869611999f7 
  3rdparty/libprocess/3rdparty/versions.am 7cb4f2f 
  src/python/setup.py.in 77fa880 

Diff: https://reviews.apache.org/r/16016/diff/


Testing (updated)
-------

make check


Thanks,

TILL TOENSHOFF