[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7104: TP fix child DS tables not loading

[GitBox <gi...@apache.org>]

ocket8888 commented on code in PR #7104:
URL: https://github.com/apache/trafficcontrol/pull/7104#discussion_r988359735


##########
traffic_portal/app/src/common/modules/table/topologyDeliveryServices/table.topologyDeliveryServices.tpl.html:
##########
@@ -26,7 +26,6 @@
 		columns="columns"
 		drop-down-options="dropDownOptions"
 		context-menu-options="contextMenuOptions"
-		sensitive-columns="sensitiveColumns"

Review Comment:
   Same as above on this table



##########
traffic_portal/app/src/common/modules/table/typeDeliveryServices/table.typeDeliveryServices.tpl.html:
##########
@@ -26,7 +26,6 @@
 		columns="columns"
 		drop-down-options="dropDownOptions"
 		context-menu-options="contextMenuOptions"
-		sensitive-columns="sensitiveColumns"

Review Comment:
   I didn't check this one but with two whole points of data I'm confident that this is broken too



##########
traffic_portal/app/src/common/modules/table/serviceCategoryDeliveryServices/table.serviceCategoryDeliveryServices.tpl.html:
##########
@@ -26,7 +26,6 @@
 		columns="columns"
 		drop-down-options="dropDownOptions"
 		context-menu-options="contextMenuOptions"
-		sensitive-columns="sensitiveColumns"

Review Comment:
   On the service category/delivery services page I can now see all the content of sensitive columns, which I think is because you removed this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org