You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/12 08:14:11 UTC
[GitHub] [rocketmq-connect] sinrimin opened a new pull request, #391: [ISSUE #337]bug fix
sinrimin opened a new pull request, #391:
URL: https://github.com/apache/rocketmq-connect/pull/391
## What is the purpose of the change
some bug fix
## Brief changelog
- Upgraded the dependency of Http SinkConnector io.openmessaging:openmessaging-connector to 0.1.4
- Fix the bug that Http SinkConnector cannot subscribe to topics
- Fixed Transform plugins not taking effect correctly (original value was returned)
- Fixed that the schemasEnabled of JsonConverter could not be set correctly
- Add the msgId to extension
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq-connect/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] sinrimin commented on a diff in pull request #391: [ISSUE #337]bug fix
Posted by GitBox <gi...@apache.org>.
sinrimin commented on code in PR #391:
URL: https://github.com/apache/rocketmq-connect/pull/391#discussion_r1046689385
##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/connectorwrapper/WorkerSinkTask.java:
##########
@@ -558,8 +558,11 @@ private ConnectRecord convertMessages(MessageExt message) {
}
// add extension
- addExtension(properties, record);
- return record;
+ addExtension(properties, transformedRecord);
+
+ // add msgId to extension
+ transformedRecord.addExtension("MQ-SYS-MSG_ID", message.getMsgId());
Review Comment:
msgId is useful in some cases, such as outputting logs. Because message key is optional. It can be placed in the addExtension method, but the method signature needs to be modified to add the message parameter. I can modify it if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] odbozhou merged pull request #391: [ISSUE #337]bug fix
Posted by GitBox <gi...@apache.org>.
odbozhou merged PR #391:
URL: https://github.com/apache/rocketmq-connect/pull/391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] odbozhou commented on a diff in pull request #391: [ISSUE #337]bug fix
Posted by GitBox <gi...@apache.org>.
odbozhou commented on code in PR #391:
URL: https://github.com/apache/rocketmq-connect/pull/391#discussion_r1050333278
##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/connectorwrapper/WorkerSinkTask.java:
##########
@@ -558,8 +558,11 @@ private ConnectRecord convertMessages(MessageExt message) {
}
// add extension
- addExtension(properties, record);
- return record;
+ addExtension(properties, transformedRecord);
+
+ // add msgId to extension
+ transformedRecord.addExtension("MQ-SYS-MSG_ID", message.getMsgId());
Review Comment:
Put it in the addExtension method, you can modify the signature
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] odbozhou commented on a diff in pull request #391: [ISSUE #337]bug fix
Posted by GitBox <gi...@apache.org>.
odbozhou commented on code in PR #391:
URL: https://github.com/apache/rocketmq-connect/pull/391#discussion_r1046633929
##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/connectorwrapper/WorkerSinkTask.java:
##########
@@ -558,8 +558,11 @@ private ConnectRecord convertMessages(MessageExt message) {
}
// add extension
- addExtension(properties, record);
- return record;
+ addExtension(properties, transformedRecord);
+
+ // add msgId to extension
+ transformedRecord.addExtension("MQ-SYS-MSG_ID", message.getMsgId());
Review Comment:
Why increase MQ-SYS-MSG_ID alone? If it is necessary to increase whether it can be put in the addExtension method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] sinrimin commented on a diff in pull request #391: [ISSUE #337]bug fix
Posted by GitBox <gi...@apache.org>.
sinrimin commented on code in PR #391:
URL: https://github.com/apache/rocketmq-connect/pull/391#discussion_r1050467930
##########
rocketmq-connect-runtime/src/main/java/org/apache/rocketmq/connect/runtime/connectorwrapper/WorkerSinkTask.java:
##########
@@ -558,8 +558,11 @@ private ConnectRecord convertMessages(MessageExt message) {
}
// add extension
- addExtension(properties, record);
- return record;
+ addExtension(properties, transformedRecord);
+
+ // add msgId to extension
+ transformedRecord.addExtension("MQ-SYS-MSG_ID", message.getMsgId());
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org