You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Sean Schofield <se...@gmail.com> on 2005/04/26 19:38:02 UTC
Re: cvs commit: incubator-myfaces/build build.xml
Grant,
Is there a reason why you made this change? It seems to break things
by generated a file named ${sign.script} in the build dir instead of
build/release/sign.sh as its supposed to. I am going to revert the
change.
sean
On 26 Apr 2005 04:14:00 -0000, grantsmith@apache.org
<gr...@apache.org> wrote:
> grantsmith 2005/04/25 21:14:00
>
> Modified: build build.xml
> Log:
> changed property file= to name= for sign.script
>
> Revision Changes Path
> 1.99 +1 -1 incubator-myfaces/build/build.xml
>
> Index: build.xml
> ===================================================================
> RCS file: /home/cvs/incubator-myfaces/build/build.xml,v
> retrieving revision 1.98
> retrieving revision 1.99
> diff -u -r1.98 -r1.99
> --- build.xml 21 Apr 2005 08:18:02 -0000 1.98
> +++ build.xml 26 Apr 2005 04:14:00 -0000 1.99
> @@ -23,7 +23,7 @@
> <property name="wml.src" location="${project.dir}/src/wml"/>
> <property name="xdoclet.src" location="${project.dir}/src/xdoclet"/>
> <property name="generated.src" location="${project.dir}/src/generated"/>
> - <property file="sign.script" location="${release.dir}/sign.sh"/>
> + <property name="sign.script" location="${release.dir}/sign.sh"/>
>
> <!-- Properties -->
> <property file="build.local.properties"/>
>
>
Re: cvs commit: incubator-myfaces/build build.xml
Posted by Sean Schofield <se...@gmail.com>.
Never mind. I was confused. I saw the change in my cvs email but
hadn't actually updated yet. I now see that you were fixing a problem
and I just fixed it again (and caused a conflict.) I'm all straight
now.
sean
On 4/26/05, Sean Schofield <se...@gmail.com> wrote:
> Grant,
>
> Is there a reason why you made this change? It seems to break things
> by generated a file named ${sign.script} in the build dir instead of
> build/release/sign.sh as its supposed to. I am going to revert the
> change.
>
> sean
>
> On 26 Apr 2005 04:14:00 -0000, grantsmith@apache.org
> <gr...@apache.org> wrote:
> > grantsmith 2005/04/25 21:14:00
> >
> > Modified: build build.xml
> > Log:
> > changed property file= to name= for sign.script
> >
> > Revision Changes Path
> > 1.99 +1 -1 incubator-myfaces/build/build.xml
> >
> > Index: build.xml
> > ===================================================================
> > RCS file: /home/cvs/incubator-myfaces/build/build.xml,v
> > retrieving revision 1.98
> > retrieving revision 1.99
> > diff -u -r1.98 -r1.99
> > --- build.xml 21 Apr 2005 08:18:02 -0000 1.98
> > +++ build.xml 26 Apr 2005 04:14:00 -0000 1.99
> > @@ -23,7 +23,7 @@
> > <property name="wml.src" location="${project.dir}/src/wml"/>
> > <property name="xdoclet.src" location="${project.dir}/src/xdoclet"/>
> > <property name="generated.src" location="${project.dir}/src/generated"/>
> > - <property file="sign.script" location="${release.dir}/sign.sh"/>
> > + <property name="sign.script" location="${release.dir}/sign.sh"/>
> >
> > <!-- Properties -->
> > <property file="build.local.properties"/>
> >
> >
>
Re: cvs commit: incubator-myfaces/build build.xml
Posted by Sean Schofield <se...@gmail.com>.
Right. See my follow up email where I realized my mistake ;-)
On 4/26/05, Grant Smith <gr...@marathon-man.com> wrote:
> Sean,
>
> Please don't revert the change. the file named ${sign.script} was probably
> there from when you ran the build before I made my change. My change FIXES
> the problem you describe.
> The line:
>
> <property file="sign.script" location="${release.dir}/sign.sh"/>
>
>
> is definitely invalid. it MUST be:
>
> <property name="sign.script" location="${release.dir}/sign.sh"/>
>
> Thanks,
> Grant.
>
>
> Sean Schofield wrote:
> Grant,
>
> Is there a reason why you made this change? It seems to break things
> by generated a file named ${sign.script} in the build dir instead of
> build/release/sign.sh as its supposed to. I am going to revert the
> change.
>
> sean
>
> On 26 Apr 2005 04:14:00 -0000, grantsmith@apache.org
> <gr...@apache.org> wrote:
>
>
> grantsmith 2005/04/25 21:14:00
>
> Modified: build build.xml
> Log:
> changed property file= to name= for sign.script
>
> Revision Changes Path
> 1.99 +1 -1 incubator-myfaces/build/build.xml
>
> Index: build.xml
> ===================================================================
> RCS file: /home/cvs/incubator-myfaces/build/build.xml,v
> retrieving revision 1.98
> retrieving revision 1.99
> diff -u -r1.98 -r1.99
> --- build.xml 21 Apr 2005 08:18:02 -0000 1.98
> +++ build.xml 26 Apr 2005 04:14:00 -0000 1.99
> @@ -23,7 +23,7 @@
> <property name="wml.src" location="${project.dir}/src/wml"/>
> <property name="xdoclet.src" location="${project.dir}/src/xdoclet"/>
> <property name="generated.src" location="${project.dir}/src/generated"/>
> - <property file="sign.script" location="${release.dir}/sign.sh"/>
> + <property name="sign.script" location="${release.dir}/sign.sh"/>
>
> <!-- Properties -->
> <property file="build.local.properties"/>
>
>
>
> .
>
>
>
>