You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by imduffy15 <gi...@git.apache.org> on 2017/11/08 14:05:52 UTC
[GitHub] any23 pull request #47: Support attribute content on all fields.
GitHub user imduffy15 opened a pull request:
https://github.com/apache/any23/pull/47
Support attribute content on all fields.
<sometag content="something" /> should be considered, regardless if `content` is not a valid
attribute of `sometag`.
The specification for microdata[1] details that an elements content attribute should be considered
before text content.
Any23 doesn't currently do this, it only considers `content` for `meta` tags which is the only
HTML tag which is suppose to have a `content` but not all sites follow HTML specifications.
Updating the microdata parser to be able to get `content` from any element should it exist.
[1] https://www.w3.org/TR/microdata/#values
Signed-off-by: Ian Duffy <ia...@zalando.ie>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/imduffy15/any23 master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit 28a68b535285f9d084725728f758272a3eda21be
Author: Ian Duffy <ia...@zalando.ie>
Date: 2017-11-08T13:59:42Z
Support attribute content on all fields.
<sometag content="something" /> should be considered, regardless if `content` is not a valid
attribute of `sometag`.
The specification for microdata[1] details that an elements content attribute should be considered
before text content.
Any23 doesn't currently do this, it only considers `content` for `meta` tags which is the only
HTML tag which is suppose to have a `content` but not all sites follow HTML specifications.
Updating the microdata parser to be able to get `content` from any element should it exist.
[1] https://www.w3.org/TR/microdata/#values
Signed-off-by: Ian Duffy <ia...@zalando.ie>
----
---
[GitHub] any23 issue #47: Support attribute content on all fields.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/47
Hi @imduffy15 thank you for the PR
In the future if you would please open a JIRA issue over on the ANY23 JIRA issue tracker and name your PR title with the same title as your JIRA issue it means our Github + JIRA hooks cross post the contribution and we can include your contribution in our release report for the next Any23 release.
I pulled this PR tested locally and all looks good. I also re-read the W3C specification and it looks fine.
```
[INFO] Apache Any23 ....................................... SUCCESS [ 8.708 s]
[INFO] Apache Any23 :: Base API ........................... SUCCESS [ 1.959 s]
[INFO] Apache Any23 :: Test Resources ..................... SUCCESS [ 0.224 s]
[INFO] Apache Any23 :: CSV Utilities ...................... SUCCESS [ 0.278 s]
[INFO] Apache Any23 :: Mime Type Detection ................ SUCCESS [ 3.145 s]
[INFO] Apache Any23 :: Encoding Detection ................. SUCCESS [ 1.239 s]
[INFO] Apache Any23 :: Core ............................... SUCCESS [ 17.691 s]
[INFO] Apache Any23 :: Plugins :: Office Scraper .......... SUCCESS [ 4.554 s]
[INFO] Apache Any23 :: Plugins :: HTML Scraper ............ SUCCESS [ 2.090 s]
[INFO] Apache Any23 :: CLI ................................ SUCCESS [ 13.399 s]
[INFO] Apache Any23 :: OpenIE ............................. SUCCESS [ 1.247 s]
[INFO] Apache Any23 :: Plugins :: Basic Crawler ........... SUCCESS [ 26.509 s]
[INFO] Apache Any23 :: Plugins :: Integration Test ........ SUCCESS [ 50.868 s]
[INFO] Apache Any23 :: Service ............................ SUCCESS [ 19.352 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:31 min
[INFO] Finished at: 2017-11-14T21:05:32-08:00
[INFO] Final Memory: 87M/1432M
[INFO] ------------------------------------------------------------------------
```
---
[GitHub] any23 issue #47: Support attribute content on all fields.
Posted by imduffy15 <gi...@git.apache.org>.
Github user imduffy15 commented on the issue:
https://github.com/apache/any23/pull/47
> In the future if you would please open a JIRA issue over on the ANY23 JIRA issue tracker
Sure, can you please create a CONTRIBUTING.md file in the root of the repository outlining these guidelines? https://github.com/blog/1184-contributing-guidelines example: https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Additionally, it might be useful to document the workflow on https://any23.apache.org/project-info.html
> I pulled this PR tested locally and all looks good
It would be neat if we could get this automated for free by using https://travis-ci.org/ and get the reports on PRs
I would imagine a `.travis.yml` as simple as this would work:
```
language: java
```
Ref: https://docs.travis-ci.com/user/languages/java
> I also re-read the W3C specification and it looks fine
Thank you for taking the time to review :)
---
[GitHub] any23 pull request #47: Support attribute content on all fields.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/any23/pull/47
---
[GitHub] any23 issue #47: Support attribute content on all fields.
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/47
@imduffy15 done https://github.com/apache/any23/blob/master/CONTRIBUTING.md, thanks for the suggestion I completely agree.
Regarding TravisCI, we already have a pretty well configured Jenkins build at https://builds.apache.org/view/A/view/Any23/job/Any23-trunk/, i think we just need to tinker with it in order to build pull requests against master branch.
I just tried to activate the trigger, we will see when the next PR comes in.
---