You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martijn Dashorst (JIRA)" <ji...@apache.org> on 2011/04/26 14:23:03 UTC
[jira] [Created] (WICKET-3646) RequestHandler listeners are called
with null handler
RequestHandler listeners are called with null handler
-----------------------------------------------------
Key: WICKET-3646
URL: https://issues.apache.org/jira/browse/WICKET-3646
Project: Wicket
Issue Type: Bug
Components: wicket-core
Affects Versions: 1.5-RC3
Reporter: Martijn Dashorst
Priority: Minor
When running RequestCycleListeners with WicketTester, they get called with null for the requesthandler in onScheduleHandler(). This is an artifact of the wicket tester requestcycle, which I think should normally not occur in Wicket processing. The parameters are not marked as optional, so it is IMO safe to assume that handler should never be null.
I propose to modify scheduleRequestHandlerAfterCurrent(IRequestHandler handler) to not invoke the listeners when the handler is null, but only to clear the current scheduled handler.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-3646) RequestHandler listeners are called
with null handler
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst reassigned WICKET-3646:
----------------------------------------
Assignee: Martijn Dashorst
> RequestHandler listeners are called with null handler
> -----------------------------------------------------
>
> Key: WICKET-3646
> URL: https://issues.apache.org/jira/browse/WICKET-3646
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC3
> Reporter: Martijn Dashorst
> Assignee: Martijn Dashorst
> Priority: Minor
>
> When running RequestCycleListeners with WicketTester, they get called with null for the requesthandler in onScheduleHandler(). This is an artifact of the wicket tester requestcycle, which I think should normally not occur in Wicket processing. The parameters are not marked as optional, so it is IMO safe to assume that handler should never be null.
> I propose to modify scheduleRequestHandlerAfterCurrent(IRequestHandler handler) to not invoke the listeners when the handler is null, but only to clear the current scheduled handler.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3646) RequestHandler listeners are called
with null handler
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst resolved WICKET-3646.
--------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC4
Fixed by implementing proposed solution. All tests still work fine (except those tests that tested the previous behavior).
> RequestHandler listeners are called with null handler
> -----------------------------------------------------
>
> Key: WICKET-3646
> URL: https://issues.apache.org/jira/browse/WICKET-3646
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC3
> Reporter: Martijn Dashorst
> Assignee: Martijn Dashorst
> Priority: Minor
> Fix For: 1.5-RC4
>
>
> When running RequestCycleListeners with WicketTester, they get called with null for the requesthandler in onScheduleHandler(). This is an artifact of the wicket tester requestcycle, which I think should normally not occur in Wicket processing. The parameters are not marked as optional, so it is IMO safe to assume that handler should never be null.
> I propose to modify scheduleRequestHandlerAfterCurrent(IRequestHandler handler) to not invoke the listeners when the handler is null, but only to clear the current scheduled handler.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (WICKET-3646) RequestHandler listeners are called
with null handler
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst closed WICKET-3646.
------------------------------------
> RequestHandler listeners are called with null handler
> -----------------------------------------------------
>
> Key: WICKET-3646
> URL: https://issues.apache.org/jira/browse/WICKET-3646
> Project: Wicket
> Issue Type: Bug
> Components: wicket-core
> Affects Versions: 1.5-RC3
> Reporter: Martijn Dashorst
> Assignee: Martijn Dashorst
> Priority: Minor
> Fix For: 1.5-RC4
>
>
> When running RequestCycleListeners with WicketTester, they get called with null for the requesthandler in onScheduleHandler(). This is an artifact of the wicket tester requestcycle, which I think should normally not occur in Wicket processing. The parameters are not marked as optional, so it is IMO safe to assume that handler should never be null.
> I propose to modify scheduleRequestHandlerAfterCurrent(IRequestHandler handler) to not invoke the listeners when the handler is null, but only to clear the current scheduled handler.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira