You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2014/01/29 04:39:05 UTC
Review Request 17481: Fixed the use of a raw unix time in the Slave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17481/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Bugs: MESOS-952
https://issues.apache.org/jira/browse/MESOS-952
Repository: mesos-git
Description
-------
The slave was relying on a raw unix time stamp to compute garbage collection times.
This is unreliable for testing purposes because we need to adjust the time based on the libprocess clock.
Diffs
-----
src/slave/slave.cpp 8b83dacad802a5434bf76ca075b2b8113ed14a84
Diff: https://reviews.apache.org/r/17481/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 17481: Fixed the use of a raw unix time in the Slave.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17481/#review33110
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/17481/#comment62386>
Let's add a comment for our readers explaining why we need to use Time::create so people do this other places too! Also, what's the convention here for the '_'? You could just call it 'time' too.
- Benjamin Hindman
On Jan. 29, 2014, 3:39 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17481/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 3:39 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-952
> https://issues.apache.org/jira/browse/MESOS-952
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The slave was relying on a raw unix time stamp to compute garbage collection times.
> This is unreliable for testing purposes because we need to adjust the time based on the libprocess clock.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8b83dacad802a5434bf76ca075b2b8113ed14a84
>
> Diff: https://reviews.apache.org/r/17481/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 17481: Fixed the use of a raw unix time in the Slave.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17481/
-----------------------------------------------------------
(Updated Jan. 29, 2014, 8:27 p.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Added a comment and cleaned up a variable name.
Bugs: MESOS-952
https://issues.apache.org/jira/browse/MESOS-952
Repository: mesos-git
Description
-------
The slave was relying on a raw unix time stamp to compute garbage collection times.
This is unreliable for testing purposes because we need to adjust the time based on the libprocess clock.
Diffs (updated)
-----
src/slave/slave.cpp 2d21e16a04d8f2419d8dee6c18664f1024bb8e73
Diff: https://reviews.apache.org/r/17481/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 17481: Fixed the use of a raw unix time in the Slave.
Posted by Vinod Kone <vi...@gmail.com>.
> On Jan. 29, 2014, 4:35 a.m., Vinod Kone wrote:
> > src/slave/slave.cpp, lines 2870-2871
> > <https://reviews.apache.org/r/17481/diff/1/?file=453440#file453440line2870>
> >
> > How is this using libprocess clock?
never mind. i didn't see the dependee review.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17481/#review33090
-----------------------------------------------------------
On Jan. 29, 2014, 3:39 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17481/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 3:39 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-952
> https://issues.apache.org/jira/browse/MESOS-952
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The slave was relying on a raw unix time stamp to compute garbage collection times.
> This is unreliable for testing purposes because we need to adjust the time based on the libprocess clock.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8b83dacad802a5434bf76ca075b2b8113ed14a84
>
> Diff: https://reviews.apache.org/r/17481/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 17481: Fixed the use of a raw unix time in the Slave.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17481/#review33090
-----------------------------------------------------------
src/slave/slave.cpp
<https://reviews.apache.org/r/17481/#comment62355>
How is this using libprocess clock?
- Vinod Kone
On Jan. 29, 2014, 3:39 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17481/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 3:39 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-952
> https://issues.apache.org/jira/browse/MESOS-952
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The slave was relying on a raw unix time stamp to compute garbage collection times.
> This is unreliable for testing purposes because we need to adjust the time based on the libprocess clock.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 8b83dacad802a5434bf76ca075b2b8113ed14a84
>
> Diff: https://reviews.apache.org/r/17481/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>