[GitHub] [incubator-superset] ktmud commented on pull request #11160: refactor: Replace react-bootstrap Tabs with Antd Tabs in DashboardBuilder

[GitBox <gi...@apache.org>]

ktmud commented on pull request #11160:
URL: https://github.com/apache/incubator-superset/pull/11160#issuecomment-705763689


   Not a designer, but I also feel the original design is a cleaner and better user experience. It'd be a little weird to have different visual styles (line vs card) for tabs in View and in Edit modes.
   
   In general, we should probably limit style changes when replacing Bootstrap components. For this case, it'd be easier and less risky if we had just kept the original editing functionalities and only replaced the `BootstrapTabs` component itself.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org