You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@servicecomb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/03 07:34:00 UTC

[jira] [Commented] (SCB-800) Param order generated by BeanParamAnnotationProcessor is not stable

    [ https://issues.apache.org/jira/browse/SCB-800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567890#comment-16567890 ] 

ASF GitHub Bot commented on SCB-800:
------------------------------------

yhs0092 opened a new pull request #855: [SCB-800] params in BeanParam is generated by declared field order
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/855
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   See details in [SCB-800](https://issues.apache.org/jira/browse/SCB-800)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Param order generated by BeanParamAnnotationProcessor is not stable
> -------------------------------------------------------------------
>
>                 Key: SCB-800
>                 URL: https://issues.apache.org/jira/browse/SCB-800
>             Project: Apache ServiceComb
>          Issue Type: Bug
>            Reporter: YaoHaishi
>            Assignee: YaoHaishi
>            Priority: Major
>
> BeanParamAnnotationProcessor process the params defined by setter methods in the order of the return value of getDeclaredMethods(). But getDeclaredMethods() does not gurantee the order of the returned array. As a result, the schemas generated by the same version of microservice instances may be different.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)