You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/10/20 07:54:23 UTC
[PR] Preserve LOAD failure details in logs and client responses [iotdb]
Caideyipi opened a new pull request, #18935:
URL: https://github.com/apache/iotdb/pull/18935
## Description
When LOAD falls back to tablet conversion, a model-read or conversion exception can be hidden by the earlier analysis error, and scheduler fallback reports only failed file paths. Remote dispatch also replaces a receiver rejection with a generic `DISPATCH_ERROR`.
- Report the current model-read or conversion failure, including the affected TsFile, in logs and client responses. Keep exception stack traces and explain conversions that return no status.
- Include each failed file's conversion status or exception in the final scheduler response, including nested insertion errors. Successful files stay out of the failure summary.
- Preserve receiver status codes, nested statuses, redirection, and retry metadata. Log rejected requests with the LOAD UUID, region, and endpoint, and handle rejections without a status explicitly.
- Add matching English and Chinese message constants and regression coverage for both file models.
## Validation
- `mvn spotless:apply -pl iotdb-core/datanode`
- Full-reactor English compilation: `mvn -nsu test-compile -DskipTests`.
- 34 targeted tests passed: `mvn -nsu surefire:test -pl iotdb-core/datanode -Dtest=LoadTsFileAnalyzerDiagnosticsTest,LoadFallbackHandlerTest,LoadTsFileDispatcherImplTest,LoadTsFileAnalyzerTest,LoadTsFileSchedulerTest -DforkCount=1`.
- English/Chinese message-key parity, new-message placeholder/hash checks, and a scan for added user-facing English literals.
- Full-reactor Chinese compilation is in progress (`mvn -nsu test-compile -DskipTests -P with-zh-locale`).
This PR has:
- [x] been self-reviewed.
- [x] added unit tests or modified existing tests to cover the changed error paths.
Key changed classes: `LoadTsFileAnalyzer`, `LoadFallbackHandler`, `LoadTsFileDispatcherImpl`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Preserve LOAD failure details in logs and client responses [iotdb]
Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18935:
URL: https://github.com/apache/iotdb/pull/18935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org