[GitHub] [spark] attilapiros commented on a change in pull request #24072: [SPARK-27112] : Spark Scheduler encounters two independent Deadlocks …

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #24072: [SPARK-27112] : Spark Scheduler encounters two independent Deadlocks …
URL: https://github.com/apache/spark/pull/24072#discussion_r264859758
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ##########
 @@ -631,8 +635,10 @@ class CoarseGrainedSchedulerBackend(scheduler: TaskSchedulerImpl, val rpcEnv: Rp
       force: Boolean): Seq[String] = {
     logInfo(s"Requesting to kill executor(s) ${executorIds.mkString(", ")}")
 
+    val idleExecutorIds = executorIds.filter { id => force || !scheduler.isExecutorBusy(id) }
 
 Review comment:
   Nit: I would not use the name `idleExecutorIds` for this variable as when flag `force` is true then not only idle executors are contained.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org