You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "jomin7 (via GitHub)" <gi...@apache.org> on 2026/06/17 10:57:33 UTC
[PR] Fixes #8685 Add github2 extension [camel-quarkus]
jomin7 opened a new pull request, #8767:
URL: https://github.com/apache/camel-quarkus/pull/8767
Fixes #8685 Add github2 extension
Add Camel Quarkus extension for the camel-github2 component backed by the kohsuke github-api library.
- Extension with native support (runtime + deployment modules)
- GraalVM substitution for DefaultGitHubConnector to remove OkHttp class references when OkHttp is absent from the classpath
- Integration tests with WireMock covering GETCOMMITFILE, GHRepository and GHCommit model deserialization
- BOM, catalog, and documentation entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes #8685 Add github2 extension [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #8767:
URL: https://github.com/apache/camel-quarkus/pull/8767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes #8685 Add github2 extension [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #8767:
URL: https://github.com/apache/camel-quarkus/pull/8767#discussion_r3427929156
##########
extensions/github2/deployment/src/main/java/org/apache/camel/quarkus/component/github2/deployment/Github2Processor.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.github2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.AdditionalApplicationArchiveMarkerBuildItem;
+import io.quarkus.deployment.builditem.ExtensionSslNativeSupportBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+
+class Github2Processor {
+
+ private static final String FEATURE = "camel-github2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ ExtensionSslNativeSupportBuildItem activateSslNativeSupport() {
+ return new ExtensionSslNativeSupportBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ AdditionalApplicationArchiveMarkerBuildItem kohsukeArchiveMarker() {
+ return new AdditionalApplicationArchiveMarkerBuildItem("org/kohsuke/github");
+ }
Review Comment:
Do we need this? I suspect we do not.
##########
extensions/github2/deployment/src/main/java/org/apache/camel/quarkus/component/github2/deployment/Github2Processor.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.github2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.AdditionalApplicationArchiveMarkerBuildItem;
+import io.quarkus.deployment.builditem.ExtensionSslNativeSupportBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+
+class Github2Processor {
+
+ private static final String FEATURE = "camel-github2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ ExtensionSslNativeSupportBuildItem activateSslNativeSupport() {
+ return new ExtensionSslNativeSupportBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ AdditionalApplicationArchiveMarkerBuildItem kohsukeArchiveMarker() {
+ return new AdditionalApplicationArchiveMarkerBuildItem("org/kohsuke/github");
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitGitHubConnector() {
+ return new RuntimeInitializedClassBuildItem("org.kohsuke.github.connector.GitHubConnector");
+ }
Review Comment:
If `GitHubConnector` is on the classpath. Then use `GitHubConnector.class.getName()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes #8685 Add github2 extension [camel-quarkus]
Posted by "jomin7 (via GitHub)" <gi...@apache.org>.
jomin7 commented on code in PR #8767:
URL: https://github.com/apache/camel-quarkus/pull/8767#discussion_r3428437534
##########
extensions/github2/deployment/src/main/java/org/apache/camel/quarkus/component/github2/deployment/Github2Processor.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.github2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.AdditionalApplicationArchiveMarkerBuildItem;
+import io.quarkus.deployment.builditem.ExtensionSslNativeSupportBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+
+class Github2Processor {
+
+ private static final String FEATURE = "camel-github2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ ExtensionSslNativeSupportBuildItem activateSslNativeSupport() {
+ return new ExtensionSslNativeSupportBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ AdditionalApplicationArchiveMarkerBuildItem kohsukeArchiveMarker() {
+ return new AdditionalApplicationArchiveMarkerBuildItem("org/kohsuke/github");
+ }
+
+ @BuildStep
+ RuntimeInitializedClassBuildItem runtimeInitGitHubConnector() {
+ return new RuntimeInitializedClassBuildItem("org.kohsuke.github.connector.GitHubConnector");
+ }
Review Comment:
Thanks James.updated to use GitHubConnector.class.getName().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixes #8685 Add github2 extension [camel-quarkus]
Posted by "jomin7 (via GitHub)" <gi...@apache.org>.
jomin7 commented on code in PR #8767:
URL: https://github.com/apache/camel-quarkus/pull/8767#discussion_r3428436608
##########
extensions/github2/deployment/src/main/java/org/apache/camel/quarkus/component/github2/deployment/Github2Processor.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.github2.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.AdditionalApplicationArchiveMarkerBuildItem;
+import io.quarkus.deployment.builditem.ExtensionSslNativeSupportBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.RuntimeInitializedClassBuildItem;
+
+class Github2Processor {
+
+ private static final String FEATURE = "camel-github2";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ ExtensionSslNativeSupportBuildItem activateSslNativeSupport() {
+ return new ExtensionSslNativeSupportBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ AdditionalApplicationArchiveMarkerBuildItem kohsukeArchiveMarker() {
+ return new AdditionalApplicationArchiveMarkerBuildItem("org/kohsuke/github");
+ }
Review Comment:
You're right, removed. The original github extension needs it for the Jandex index scan in registerForReflection, but we don't have anything querying the index here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org