You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Tamas Cservenak (Jira)" <ji...@apache.org> on 2024/04/03 11:39:00 UTC

[jira] [Closed] (MRESOLVER-521) File locking threads not entering critical region were "oversleeping"

     [ https://issues.apache.org/jira/browse/MRESOLVER-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tamas Cservenak closed MRESOLVER-521.
-------------------------------------
    Resolution: Fixed

> File locking threads not entering critical region were "oversleeping"
> ---------------------------------------------------------------------
>
>                 Key: MRESOLVER-521
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-521
>             Project: Maven Resolver
>          Issue Type: Bug
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 2.0.0, 2.0.0-alpha-11
>
>
> Instead loser to immediately give up and sleep, should sit a while to enter critical region. This is important for "hot" locks.
> Explanation: currently a "loser" will _immediately give up_ and will go to sleep 100ms, even if winner exits critical region within next 5ms (so lost 95ms). The retry is needed to ensure that it is retried as much as given time/unit takes, that was before consumed by constant retries+sleeps. The logic still works, as if tryLock spends time/unit waiting on critical region (which is possible only on VERY HIGHLY congested locks), there will be no retry happening. Still, now it may sleep 5ms, and "win" once "original winner" left the critical region.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)