[GitHub] [lucene] uschindler commented on a diff in pull request #802: Check module access prior to running gjf/spotless tasks

[GitBox <gi...@apache.org>]

uschindler commented on code in PR #802:
URL: https://github.com/apache/lucene/pull/802#discussion_r846368634


##########
gradle/validation/spotless.gradle:
##########
@@ -22,6 +22,19 @@
 
 def resources = scriptResources(buildscript)
 
+// Check that GJF has access to jdk.compiler internals (this is set up
+// in gradle JVM options via the generated gradle.properties).
+def checkGoogleFormatHasAccessToJdkInternals = rootProject.tasks.register("checkGoogleFormatHasAccessToJdkInternals", {
+  doFirst {
+    def isExported = ModuleLayer.boot().findModule("jdk.compiler")
+        .get().isExported("com.sun.tools.javac.parser", getClass().module)

Review Comment:
   we should maybe check all required packages?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org