You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/02/01 11:38:44 UTC

[GitHub] zhaijack opened a new pull request #1165: PIP-13-2: support regex based subscription

zhaijack opened a new pull request #1165: PIP-13-2: support regex based subscription
URL: https://github.com/apache/incubator-pulsar/pull/1165
 
 
   This change is based on work of #1103, which already contains the first 3 commits there. In this PR, the commits after the first 3 are for this sub-task. 
   
   ### Motivation
   This is a second sub-task for pip-13, which would like to leverage the first task to support regex based subscription.
   
   ### Modifications
   - add subscribe methods with regex pattern in `PulsarClient` and `PulsarClientImpl`.
   - add `PatternTopicsConsumerImpl`, which extends `TopicsConsumerImpl`.
   - add a binary proto command to get topics under a namespace. 
   - add a test to verify.
   
   ### Result
   old methods behaviour not changed, 
   user could use new method to subscribe to topics based on regex pattern

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services