You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/05 21:32:12 UTC

[GitHub] [iceberg] aokolnychyi commented on pull request #2210: Adds AddFiles Procedure

aokolnychyi commented on pull request #2210:
URL: https://github.com/apache/iceberg/pull/2210#issuecomment-791723338


   I did one thorough pass. I think there is a temp consensus on inferring partitions in this PR and we can use Spark's in-memory file index for now until we have our own solution.
   
   I think we need to rename `partition` into `partition_filter` and don't require all columns. Also, it would be great to test special chars and spaces in partition names. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org