You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/30 20:56:19 UTC

[GitHub] [cloudstack] ustcweizhou opened a new pull request #4000: vm: Reset deviceId to fix missing nic with vm

ustcweizhou opened a new pull request #4000: vm: Reset deviceId to fix missing nic with vm
URL: https://github.com/apache/cloudstack/pull/4000
 
 
   ## Description
   <!--- Describe your changes in detail -->
   
   This PR aims to fix the issue which can be reproduced as below:
   
   1. create a vm with 3 networks
   2. remove the 2nd network from the vm
   3. stop the vm
   4. start the vm
   
   Expected result: vm is started with 2 nics (on 1st network and 3rd network)
   Actual result: vm is started with only first nic (on 1st network).
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   <!-- Include details of your testing environment, and the tests you ran to -->
   <!-- see how your change affects other areas of the code, etc. -->
   
   With this PR, the vm is started with all nics.
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services