[jira] [Resolved] (SYNCOPE-417) Users are made active when updating in NoOpWorkflowAdapter

["Francesco Chicchiriccò (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SYNCOPE-417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Chicchiriccò resolved SYNCOPE-417.
--------------------------------------------

    Resolution: Fixed

1_1_X: http://svn.apache.org/r1524937
trunk: http://svn.apache.org/r1524938

Patch applied (better from source root directory, next time), thanks!
                
> Users are made active when updating in NoOpWorkflowAdapter
> ----------------------------------------------------------
>
>                 Key: SYNCOPE-417
>                 URL: https://issues.apache.org/jira/browse/SYNCOPE-417
>             Project: Syncope
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.1.3
>            Reporter: Jesse van Bekkum
>            Assignee: Francesco Chicchiriccò
>            Priority: Minor
>             Fix For: 1.1.4, 1.2.0
>
>         Attachments: NoOpUserWorkflowAdapter.java.patch
>
>
> When using the NoOpWorkflow adapter a user is always set to active when an update is done, even if the user is suspended. This is undesirable, I think a user should stay in the state it is.
> This can be fixed by changing this line (117/118 of NoOpWorkflowAdapter.java):
>         return new WorkflowResult<Map.Entry<Long, Boolean>>(
>                 new AbstractMap.SimpleEntry<Long, Boolean>(updated.getId(), true), propByRes, "update");
> into this:
>         return new WorkflowResult<Map.Entry<Long, Boolean>>(
>                 new AbstractMap.SimpleEntry<Long, Boolean>(updated.getId(), !user.isSuspended()), propByRes, "update");

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira