You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Mickael Maison <mi...@gmail.com> on 2026/10/22 15:25:41 UTC
Re: [VOTE] KIP-1308: Extend Header API for Common Value Types
Hi,
Thanks for the KIP
+1 (binding)
Thanks,
Mickael
On Tue, Aug 18, 2026 at 8:49 PM Aditya Kousik <ad...@icloud.com> wrote:
>
> Greetings,
>
> Gentle ping on this KIP. With the proposal, we can swap record.headers().add(“isRetryRecord”, new byte[] { 0x0 }); with record.headers.add(“isRetryRecord”, false); similarly for other plain datatypes.
>
> Best,
> Aditya
>
> > On May 26, 2026, at 22:23, Aditya Kousik <ad...@icloud.com> wrote:
> >
> > Hi all,
> >
> > I'd like to start the vote for KIP-1308.
> >
> > KIP Design doc: https://cwiki.apache.org/confluence/x/FpY8G
> > Discussion thread: https://lists.apache.org/thread/odpnx9ttbws0fjhfh07vspb5mklv2zq4
> >
> > Thanks and regards,
> > Aditya Kousik
Re: [VOTE] KIP-1308: Extend Header API for Common Value Types
Posted by Aditya Kousik via dev <de...@kafka.apache.org>.
Indeed. I’ve removed the dangling reference.
> On Oct 23, 2026, at 08:31, Andrew Schofield <sc...@apache.org> wrote:
>
> Thanks for the update. I think there's an orphaned "ofStringUtf8" floating around in there.
>
> Thanks,
> Andrew
>
>> On 2026/10/23 15:17:53 Aditya Kousik via dev wrote:
>> Thank you both.
>>
>> Mickael, thank you for the last minute catch. I’ve moved the abstract methods to rejected alternatives and added default methods to both Header/Headers.
>>
>> This also simplifies the KIP and removes the changes affecting RecordHeader(s).
>>
>> Please take a look at the updated version.
>>
>> Best,
>> Aditya
>>
>>>> On Oct 22, 2026, at 08:31, Andrew Schofield <sc...@apache.org> wrote:
>>>
>>> +1 (binding)
>>>
>>> Thanks,
>>> Andrew
>>>
>>>> On 2026/10/22 15:25:41 Mickael Maison wrote:
>>>> Hi,
>>>>
>>>> Thanks for the KIP
>>>> +1 (binding)
>>>>
>>>> Thanks,
>>>> Mickael
>>>>
>>>>> On Tue, Aug 18, 2026 at 8:49 PM Aditya Kousik <ad...@icloud.com> wrote:
>>>>>
>>>>> Greetings,
>>>>>
>>>>> Gentle ping on this KIP. With the proposal, we can swap record.headers().add(“isRetryRecord”, new byte[] { 0x0 }); with record.headers.add(“isRetryRecord”, false); similarly for other plain datatypes.
>>>>>
>>>>> Best,
>>>>> Aditya
>>>>>
>>>>>> On May 26, 2026, at 22:23, Aditya Kousik <ad...@icloud.com> wrote:
>>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> I'd like to start the vote for KIP-1308.
>>>>>>
>>>>>> KIP Design doc: https://cwiki.apache.org/confluence/x/FpY8G
>>>>>> Discussion thread: https://lists.apache.org/thread/odpnx9ttbws0fjhfh07vspb5mklv2zq4
>>>>>>
>>>>>> Thanks and regards,
>>>>>> Aditya Kousik
>>>>
>>
Re: [VOTE] KIP-1308: Extend Header API for Common Value Types
Posted by Andrew Schofield <sc...@apache.org>.
Thanks for the update. I think there's an orphaned "ofStringUtf8" floating around in there.
Thanks,
Andrew
On 2026/10/23 15:17:53 Aditya Kousik via dev wrote:
> Thank you both.
>
> Mickael, thank you for the last minute catch. I’ve moved the abstract methods to rejected alternatives and added default methods to both Header/Headers.
>
> This also simplifies the KIP and removes the changes affecting RecordHeader(s).
>
> Please take a look at the updated version.
>
> Best,
> Aditya
>
> > On Oct 22, 2026, at 08:31, Andrew Schofield <sc...@apache.org> wrote:
> >
> > +1 (binding)
> >
> > Thanks,
> > Andrew
> >
> >> On 2026/10/22 15:25:41 Mickael Maison wrote:
> >> Hi,
> >>
> >> Thanks for the KIP
> >> +1 (binding)
> >>
> >> Thanks,
> >> Mickael
> >>
> >>> On Tue, Aug 18, 2026 at 8:49 PM Aditya Kousik <ad...@icloud.com> wrote:
> >>>
> >>> Greetings,
> >>>
> >>> Gentle ping on this KIP. With the proposal, we can swap record.headers().add(“isRetryRecord”, new byte[] { 0x0 }); with record.headers.add(“isRetryRecord”, false); similarly for other plain datatypes.
> >>>
> >>> Best,
> >>> Aditya
> >>>
> >>>> On May 26, 2026, at 22:23, Aditya Kousik <ad...@icloud.com> wrote:
> >>>>
> >>>> Hi all,
> >>>>
> >>>> I'd like to start the vote for KIP-1308.
> >>>>
> >>>> KIP Design doc: https://cwiki.apache.org/confluence/x/FpY8G
> >>>> Discussion thread: https://lists.apache.org/thread/odpnx9ttbws0fjhfh07vspb5mklv2zq4
> >>>>
> >>>> Thanks and regards,
> >>>> Aditya Kousik
> >>
>
Re: [VOTE] KIP-1308: Extend Header API for Common Value Types
Posted by Aditya Kousik via dev <de...@kafka.apache.org>.
Thank you both.
Mickael, thank you for the last minute catch. I’ve moved the abstract methods to rejected alternatives and added default methods to both Header/Headers.
This also simplifies the KIP and removes the changes affecting RecordHeader(s).
Please take a look at the updated version.
Best,
Aditya
> On Oct 22, 2026, at 08:31, Andrew Schofield <sc...@apache.org> wrote:
>
> +1 (binding)
>
> Thanks,
> Andrew
>
>> On 2026/10/22 15:25:41 Mickael Maison wrote:
>> Hi,
>>
>> Thanks for the KIP
>> +1 (binding)
>>
>> Thanks,
>> Mickael
>>
>>> On Tue, Aug 18, 2026 at 8:49 PM Aditya Kousik <ad...@icloud.com> wrote:
>>>
>>> Greetings,
>>>
>>> Gentle ping on this KIP. With the proposal, we can swap record.headers().add(“isRetryRecord”, new byte[] { 0x0 }); with record.headers.add(“isRetryRecord”, false); similarly for other plain datatypes.
>>>
>>> Best,
>>> Aditya
>>>
>>>> On May 26, 2026, at 22:23, Aditya Kousik <ad...@icloud.com> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> I'd like to start the vote for KIP-1308.
>>>>
>>>> KIP Design doc: https://cwiki.apache.org/confluence/x/FpY8G
>>>> Discussion thread: https://lists.apache.org/thread/odpnx9ttbws0fjhfh07vspb5mklv2zq4
>>>>
>>>> Thanks and regards,
>>>> Aditya Kousik
>>
Re: [VOTE] KIP-1308: Extend Header API for Common Value Types
Posted by Mickael Maison <mi...@gmail.com>.
Hi,
Actually there's a couple of compatibility issues.
This will break all custom implementations of Header and Headers. We
should probably add default methods since the logic would be the same
for custom implementations.
Also it seems add(String key, String value) may be ambiguous if called
with null because of the existing add(String key, byte[] value). Maybe
we could keep only the add(String key, String value, Charset charset)
alternative to resolve this.
Thanks,
Mickael
On Thu, Oct 22, 2026 at 5:31 PM Andrew Schofield <sc...@apache.org> wrote:
>
> +1 (binding)
>
> Thanks,
> Andrew
>
> On 2026/10/22 15:25:41 Mickael Maison wrote:
> > Hi,
> >
> > Thanks for the KIP
> > +1 (binding)
> >
> > Thanks,
> > Mickael
> >
> > On Tue, Aug 18, 2026 at 8:49 PM Aditya Kousik <ad...@icloud.com> wrote:
> > >
> > > Greetings,
> > >
> > > Gentle ping on this KIP. With the proposal, we can swap record.headers().add(“isRetryRecord”, new byte[] { 0x0 }); with record.headers.add(“isRetryRecord”, false); similarly for other plain datatypes.
> > >
> > > Best,
> > > Aditya
> > >
> > > > On May 26, 2026, at 22:23, Aditya Kousik <ad...@icloud.com> wrote:
> > > >
> > > > Hi all,
> > > >
> > > > I'd like to start the vote for KIP-1308.
> > > >
> > > > KIP Design doc: https://cwiki.apache.org/confluence/x/FpY8G
> > > > Discussion thread: https://lists.apache.org/thread/odpnx9ttbws0fjhfh07vspb5mklv2zq4
> > > >
> > > > Thanks and regards,
> > > > Aditya Kousik
> >
Re: [VOTE] KIP-1308: Extend Header API for Common Value Types
Posted by Andrew Schofield <sc...@apache.org>.
+1 (binding)
Thanks,
Andrew
On 2026/10/22 15:25:41 Mickael Maison wrote:
> Hi,
>
> Thanks for the KIP
> +1 (binding)
>
> Thanks,
> Mickael
>
> On Tue, Aug 18, 2026 at 8:49 PM Aditya Kousik <ad...@icloud.com> wrote:
> >
> > Greetings,
> >
> > Gentle ping on this KIP. With the proposal, we can swap record.headers().add(“isRetryRecord”, new byte[] { 0x0 }); with record.headers.add(“isRetryRecord”, false); similarly for other plain datatypes.
> >
> > Best,
> > Aditya
> >
> > > On May 26, 2026, at 22:23, Aditya Kousik <ad...@icloud.com> wrote:
> > >
> > > Hi all,
> > >
> > > I'd like to start the vote for KIP-1308.
> > >
> > > KIP Design doc: https://cwiki.apache.org/confluence/x/FpY8G
> > > Discussion thread: https://lists.apache.org/thread/odpnx9ttbws0fjhfh07vspb5mklv2zq4
> > >
> > > Thanks and regards,
> > > Aditya Kousik
>