[jira] [Commented] (HBASE-9820) Method Replication.decorateMasterConfiguration can fail with NPE in case that property HBASE_MASTER_LOGCLEANER_PLUGINS is not defined

["Biju Nair (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-9820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16843195#comment-16843195 ] 

Biju Nair commented on HBASE-9820:
----------------------------------

Checked current master code for {{Replication.java}} and there are no instances of {{HBASE_MASTER_LOGCLEANER_PLUGINS}} which required a default value as per the patch. Will close since this issue since is pretty old.

> Method Replication.decorateMasterConfiguration can fail with NPE in case that property HBASE_MASTER_LOGCLEANER_PLUGINS is not defined
> -------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-9820
>                 URL: https://issues.apache.org/jira/browse/HBASE-9820
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.96.0
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jean-Marc Spaggiari
>            Priority: Major
>         Attachments: HBASE-9820-v0-trunk.patch
>
>
> While upgrading HBase dependency on Pig via PIG-3529, I've noticed that method {{Replication.decorateMasterConfiguration()}} can throw {{NullPointerException}} ([code|https://github.com/apache/hbase/blob/0.96/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/Replication.java]) in case when property HBASE_MASTER_LOGCLEANER_PLUGINS won't be defined.
> The issue was more on a pig side where we weren't propagating default HBase configuration resources (such as {{hbase-default.xml}}), but I was curious if it's expected that this property will be always defined? We might want to tweak the code a bit if this property can be null.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)