Re: git commit: TS-2808 Remove confusing and probably bogus comment in TSVConnCreate

[James Peach <jp...@apache.org>]

So how does one use he TSVConn that TSVConnCreate() returns?

On May 23, 2014, at 10:10 AM, zwoop@apache.org wrote:

> Repository: trafficserver
> Updated Branches:
>  refs/heads/master 7fe24aefa -> 59fa19025
> 
> 
> TS-2808 Remove confusing and probably bogus comment in TSVConnCreate
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/trafficserver/repo
> Commit: http://git-wip-us.apache.org/repos/asf/trafficserver/commit/59fa1902
> Tree: http://git-wip-us.apache.org/repos/asf/trafficserver/tree/59fa1902
> Diff: http://git-wip-us.apache.org/repos/asf/trafficserver/diff/59fa1902
> 
> Branch: refs/heads/master
> Commit: 59fa19025f0009065ee9217117b098749d31320b
> Parents: 7fe24ae
> Author: Leif Hedstrom <zw...@apache.org>
> Authored: Fri May 23 11:10:40 2014 -0600
> Committer: Leif Hedstrom <zw...@apache.org>
> Committed: Fri May 23 11:10:44 2014 -0600
> 
> ----------------------------------------------------------------------
> proxy/InkAPI.cc   | 20 --------------------
> proxy/api/ts/ts.h | 28 ----------------------------
> 2 files changed, 48 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/59fa1902/proxy/InkAPI.cc
> ----------------------------------------------------------------------
> diff --git a/proxy/InkAPI.cc b/proxy/InkAPI.cc
> index dceea6e..3811292 100644
> --- a/proxy/InkAPI.cc
> +++ b/proxy/InkAPI.cc
> @@ -6148,26 +6148,6 @@ TSActionDone(TSAction actionp)
> 
> /* Connections */
> 
> -/* Deprectated.
> -   Do not use this API.
> -   The reason is even if VConn is created using this API, it is still useless.
> -   For example, if we do TSVConnRead, the read operation returns read_vio, if
> -   we do TSVIOReenable (read_vio), it actually calls:
> -   void VIO::reenable()
> -   {
> -       if (vc_server) vc_server->reenable(this);
> -   }
> -   vc_server->reenable calls:
> -   VConnection::reenable(VIO)
> -
> -   this function is virtual in VConnection.h. It is defined separately for
> -   UnixNet, NTNet and CacheVConnection.
> -
> -   Thus, unless VConn is either NetVConnection or CacheVConnection, it can't
> -   be instantiated for functions like reenable.
> -
> -   Meanwhile, this function has never been used.
> -   */
> TSVConn
> TSVConnCreate(TSEventFunc event_funcp, TSMutex mutexp)
> {
> 
> http://git-wip-us.apache.org/repos/asf/trafficserver/blob/59fa1902/proxy/api/ts/ts.h
> ----------------------------------------------------------------------
> diff --git a/proxy/api/ts/ts.h b/proxy/api/ts/ts.h
> index 917d6b2..30f14ce 100644
> --- a/proxy/api/ts/ts.h
> +++ b/proxy/api/ts/ts.h
> @@ -2165,35 +2165,7 @@ extern "C"
>   */
>   tsapi TSReturnCode TSHttpTxnAborted(TSHttpTxn txnp);
> 
> -  /*
> -    The reason is even if VConn is created using this API, it is
> -    still useless. For example, if we do TSVConnRead(), the read
> -    operation returns read_vio. If we do TSVIOReenable(read_vio),
> -    it actually calls:
> -
> -    @code
> -    void VIO::reenable() {
> -    if (vc_server) vc_server->reenable(this);
> -    }
> -    @endcode
> -
> -    vc_server->reenable calls:
> -
> -    @code
> -    VConnection::reenable(VIO);
> -    @endcode
> -
> -    This function is virtual in VConnection.h. It is defined separately for
> -    UnixNet, NTNet and CacheVConnection.
> -
> -    Thus, unless VConn is either NetVConnection or CacheVConnection, it can't
> -    be instantiated for functions like reenable.
> -
> -    In addition, this function has never been used.
> -
> -  */
>   tsapi TSVConn TSVConnCreate(TSEventFunc event_funcp, TSMutex mutexp);
> -
>   tsapi TSVConn TSVConnFdCreate(int fd);
> 
>   /* api functions to access stats */
>