You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@aurora.apache.org by Suman Karumuri <ma...@apache.org> on 2014/03/23 05:35:22 UTC

Review Request 19565: Role and Role/env pages for Scheduler

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/
-----------------------------------------------------------

Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-39
    https://issues.apache.org/jira/browse/AURORA-39


Repository: aurora


Description
-------

Implemented the scheduler role and role/env pages using AngularJS.

Added angular route and underscore.js modules.


Diffs
-----

  3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
  src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
  src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
  src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
  src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
  src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 

Diff: https://reviews.apache.org/r/19565/diff/


Testing
-------

./gradlew clean build run on local laptop.


Thanks,

Suman Karumuri

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Suman Karumuri <ma...@apache.org>.


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 225
> > <https://reviews.apache.org/r/19565/diff/1/?file=533620#file533620line225>
> >
> >     This method makes for difficult-to-read call-sites.  How about silent=true for everything to remove the extra flag?  You can then add the /scheduler link to / with:
> >     
> >       Registration.registerEndpoint(binder(), "/scheduler");

Yeah, this is better. Changed.


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html, line 5
> > <https://reviews.apache.org/r/19565/diff/1/?file=533622#file533622line5>
> >
> >     Consider removing the spaces on the LHS of colons:
> >     
> >       Role: myRole
> >       Environment: myEnv
> >     
> >     as opposed to
> >     
> >       Role : myRole
> >       Environment : myEnv

I wanted to remove them but wasn't sure if they were intentional so left them there. Removed now.


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html, line 7
> > <https://reviews.apache.org/r/19565/diff/1/?file=533622#file533622line7>
> >
> >     Is the extra "if" redundant here?

yes. Removed.


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/home.html, line 19
> > <https://reviews.apache.org/r/19565/diff/1/?file=533623#file533623line19>
> >
> >     columnCollection and rowCollection probably aren't the most informative names.  Can you be more descriptive?

Changed.


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 56
> > <https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line56>
> >
> >     DRY

Refactored error handling logic into a directive for more dryness.


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 81
> > <https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line81>
> >
> >     Why not:
> >     
> >     $scope.showResources = !$scope.showResources;
> >     $scope.resourceButtonText = ($scope.showResources ? 'Show' : 'Hide') + ' Resource Consumption';

Changed. Preferring separate strings for the button text separate since we can change the text in future without changing the logic or for i18n purposes. 


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 88
> > <https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line88>
> >
> >     missing semicolon

added


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 205
> > <https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line205>
> >
> >     Does it make sense to s/cronJobName/jobName/, then you can reuse the sort function? (This also results in more consistent naming.)
> >     
> >     You could take this a step further to declare a local function that produces the basic information for a job (role, environment, name), and decorate that with the type-specific fields.  Your call on that part.

Good idea. Changed. Not taking it a step further, since this code more simpler to understand. 


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 212
> > <https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line212>
> >
> >     missing semicolon

Fixed.


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 215
> > <https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line215>
> >
> >     missing semicolon

fixed


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 231
> > <https://reviews.apache.org/r/19565/diff/1/?file=533627#file533627line231>
> >
> >     missing semicolon

fixed


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/role.html, line 2
> > <https://reviews.apache.org/r/19565/diff/1/?file=533630#file533630line2>
> >
> >     This is a copy-paste from home.html, and will probably drift.  Can you use a fragment instead?

Turned it into a directive.


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/role.html, line 20
> > <https://reviews.apache.org/r/19565/diff/1/?file=533630#file533630line20>
> >
> >     funky indent?

Fixed.


> On March 24, 2014, 6:35 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/role.html, line 5
> > <https://reviews.apache.org/r/19565/diff/1/?file=533630#file533630line5>
> >
> >     Right now you have a 'global' scope with:
> >     
> >       title
> >       error
> >       reloadMsg
> >       errorMsg
> >       columnCollection
> >       role
> >       environment
> >       quotaError
> >       quotaErrorMsg
> >       jobsTableConfig
> >       jobsTableColumns
> >       cronJobsTableConfig
> >       cronJobsTableColumns
> >       showResources
> >       resourceButtonText
> >     
> >     (possibly more that i've missed)
> >     
> >     And some of these have relationships.  It would be nice to have relationships follow the scoping (i shouldn't have an errorMsg or reloadMsg without an error).  Laying out a scoping convention early will also help define the pattern before the scope becomes unwieldy.

The scope of all these variables is within the JobSummaryController and so not global. I have refactored errors into a directive to make this a bit more cleaner. I have also refactored quota code into a new controller so the JobSummaryController is more focussed. 


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38325
-----------------------------------------------------------


On March 23, 2014, 4:35 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 4:35 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38325
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/http/ServletModule.java
<https://reviews.apache.org/r/19565/#comment70369>

    This method makes for difficult-to-read call-sites.  How about silent=true for everything to remove the extra flag?  You can then add the /scheduler link to / with:
    
      Registration.registerEndpoint(binder(), "/scheduler");



src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html
<https://reviews.apache.org/r/19565/#comment70380>

    Consider removing the spaces on the LHS of colons:
    
      Role: myRole
      Environment: myEnv
    
    as opposed to
    
      Role : myRole
      Environment : myEnv



src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html
<https://reviews.apache.org/r/19565/#comment70379>

    Is the extra "if" redundant here?



src/main/resources/org/apache/aurora/scheduler/http/ui/home.html
<https://reviews.apache.org/r/19565/#comment70381>

    columnCollection and rowCollection probably aren't the most informative names.  Can you be more descriptive?



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/19565/#comment70390>

    DRY



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/19565/#comment70392>

    Why not:
    
    $scope.showResources = !$scope.showResources;
    $scope.resourceButtonText = ($scope.showResources ? 'Show' : 'Hide') + ' Resource Consumption';



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/19565/#comment70396>

    missing semicolon



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/19565/#comment70397>

    Does it make sense to s/cronJobName/jobName/, then you can reuse the sort function? (This also results in more consistent naming.)
    
    You could take this a step further to declare a local function that produces the basic information for a job (role, environment, name), and decorate that with the type-specific fields.  Your call on that part.



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/19565/#comment70395>

    missing semicolon



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/19565/#comment70393>

    missing semicolon



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/19565/#comment70394>

    missing semicolon



src/main/resources/org/apache/aurora/scheduler/http/ui/role.html
<https://reviews.apache.org/r/19565/#comment70382>

    This is a copy-paste from home.html, and will probably drift.  Can you use a fragment instead?



src/main/resources/org/apache/aurora/scheduler/http/ui/role.html
<https://reviews.apache.org/r/19565/#comment70387>

    Right now you have a 'global' scope with:
    
      title
      error
      reloadMsg
      errorMsg
      columnCollection
      role
      environment
      quotaError
      quotaErrorMsg
      jobsTableConfig
      jobsTableColumns
      cronJobsTableConfig
      cronJobsTableColumns
      showResources
      resourceButtonText
    
    (possibly more that i've missed)
    
    And some of these have relationships.  It would be nice to have relationships follow the scoping (i shouldn't have an errorMsg or reloadMsg without an error).  Laying out a scoping convention early will also help define the pattern before the scope becomes unwieldy.



src/main/resources/org/apache/aurora/scheduler/http/ui/role.html
<https://reviews.apache.org/r/19565/#comment70388>

    funky indent?


- Bill Farner


On March 23, 2014, 4:35 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 4:35 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Suman Karumuri <ma...@apache.org>.


> On March 26, 2014, 5:27 p.m., Bill Farner wrote:
> > I tried this out locally, and the browser back button appears to be broken when i click on a role, then a job.  Does this repro for you?
> > 
> > Also, the arrangement of the title, breadcrumbs, and [Show/Hide Resource Consumption] was changed (the button is directly to the right of the title, which i find odd.
> 
> Suman Karumuri wrote:
>     The breadcrumb bar should always come before the content. Hence, I moved it above the title.
>     
>     I have moved the [Show/Hide Resource Consumption] beside the title to save space and make the page more compact. Once we design the title and the button a bit (move title to the left, button to the right, turn the button into an icon) we can make it look better. I was planning to do this in Q2.
>     
>     I have noticed the back button issue also. But that seems to be an issue with how ngRoute manipulates browser history. I have investigated it but didn't find a solution. So, moved it to the back burner for now since this will be replaced with the new jobs page soon. Let me know if you want me to investigate this further now.
> 
> Bill Farner wrote:
>     We either need to fix this now or introduce them both at the same time.  I would find this extremely frustrating behavior as a user.  If you can confirm that introducing the job page (even with a dummy) fixes this, i'm fine to keep both reviews in flight and commit ~simultaneously.

Since I am mostly done with Job page. I vote for committing these changes together. In the interim, instead of a blank page, I have updated the code to open the job link in a new tab. 

Since we are pushing both of these changes together, do you want me to update this diff with the job page as well?


> On March 26, 2014, 5:27 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 137
> > <https://reviews.apache.org/r/19565/diff/2/?file=535006#file535006line137>
> >
> >     Can you elaborate?  I'm not sure the TODO has enough context for me to complete it if i wanted to.
> 
> Suman Karumuri wrote:
>     Currently, the schedule is shown as "1 * * * *". Most people don't understand what it means. It would nice if we can show some explanation like "Run this cron job on the first minute of every hour of every day" in a tooltip.
> 
> Bill Farner wrote:
>     In that case, i vote for removal of the TODO, and possibly opening the discussion in a ticket or IRC.  I think Kevin's data mining of in-use cron schedules may make you reconsider this desire.

Dropped.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38627
-----------------------------------------------------------


On March 26, 2014, 11:01 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 11:01 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Suman Karumuri <ma...@apache.org>.


> On March 26, 2014, 5:27 p.m., Bill Farner wrote:
> > I tried this out locally, and the browser back button appears to be broken when i click on a role, then a job.  Does this repro for you?
> > 
> > Also, the arrangement of the title, breadcrumbs, and [Show/Hide Resource Consumption] was changed (the button is directly to the right of the title, which i find odd.

The breadcrumb bar should always come before the content. Hence, I moved it above the title.

I have moved the [Show/Hide Resource Consumption] beside the title to save space and make the page more compact. Once we design the title and the button a bit (move title to the left, button to the right, turn the button into an icon) we can make it look better. I was planning to do this in Q2.

I have noticed the back button issue also. But that seems to be an issue with how ngRoute manipulates browser history. I have investigated it but didn't find a solution. So, moved it to the back burner for now since this will be replaced with the new jobs page soon. Let me know if you want me to investigate this further now.


> On March 26, 2014, 5:27 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 137
> > <https://reviews.apache.org/r/19565/diff/2/?file=535006#file535006line137>
> >
> >     Can you elaborate?  I'm not sure the TODO has enough context for me to complete it if i wanted to.

Currently, the schedule is shown as "1 * * * *". Most people don't understand what it means. It would nice if we can show some explanation like "Run this cron job on the first minute of every hour of every day" in a tooltip. 


> On March 26, 2014, 5:27 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/error.html, line 6
> > <https://reviews.apache.org/r/19565/diff/2/?file=535001#file535001line6>
> >
> >     Still not clear on why there's an error flag and an errorMsg string.  Can the string serve as both?  This allows you to avoid the erroneous conditions of error=true, errorMsg=null, and error=false,errorMsg='Some error'

Good idea. Will look into this.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38627
-----------------------------------------------------------


On March 25, 2014, 2:55 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 2:55 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Bill Farner <wf...@apache.org>.


> On March 26, 2014, 5:27 p.m., Bill Farner wrote:
> > I tried this out locally, and the browser back button appears to be broken when i click on a role, then a job.  Does this repro for you?
> > 
> > Also, the arrangement of the title, breadcrumbs, and [Show/Hide Resource Consumption] was changed (the button is directly to the right of the title, which i find odd.
> 
> Suman Karumuri wrote:
>     The breadcrumb bar should always come before the content. Hence, I moved it above the title.
>     
>     I have moved the [Show/Hide Resource Consumption] beside the title to save space and make the page more compact. Once we design the title and the button a bit (move title to the left, button to the right, turn the button into an icon) we can make it look better. I was planning to do this in Q2.
>     
>     I have noticed the back button issue also. But that seems to be an issue with how ngRoute manipulates browser history. I have investigated it but didn't find a solution. So, moved it to the back burner for now since this will be replaced with the new jobs page soon. Let me know if you want me to investigate this further now.
> 
> Bill Farner wrote:
>     We either need to fix this now or introduce them both at the same time.  I would find this extremely frustrating behavior as a user.  If you can confirm that introducing the job page (even with a dummy) fixes this, i'm fine to keep both reviews in flight and commit ~simultaneously.
> 
> Suman Karumuri wrote:
>     Since I am mostly done with Job page. I vote for committing these changes together. In the interim, instead of a blank page, I have updated the code to open the job link in a new tab. 
>     
>     Since we are pushing both of these changes together, do you want me to update this diff with the job page as well?

Your reply seems to imply that the back button issue is fixed when the new job page is added.  Can you explicitly confirm that?

Iff the new job page fixes the back button issue, i'm fine with merging the diffs into this review.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38627
-----------------------------------------------------------


On March 27, 2014, 9:04 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 9:04 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Bill Farner <wf...@apache.org>.


> On March 26, 2014, 5:27 p.m., Bill Farner wrote:
> > I tried this out locally, and the browser back button appears to be broken when i click on a role, then a job.  Does this repro for you?
> > 
> > Also, the arrangement of the title, breadcrumbs, and [Show/Hide Resource Consumption] was changed (the button is directly to the right of the title, which i find odd.
> 
> Suman Karumuri wrote:
>     The breadcrumb bar should always come before the content. Hence, I moved it above the title.
>     
>     I have moved the [Show/Hide Resource Consumption] beside the title to save space and make the page more compact. Once we design the title and the button a bit (move title to the left, button to the right, turn the button into an icon) we can make it look better. I was planning to do this in Q2.
>     
>     I have noticed the back button issue also. But that seems to be an issue with how ngRoute manipulates browser history. I have investigated it but didn't find a solution. So, moved it to the back burner for now since this will be replaced with the new jobs page soon. Let me know if you want me to investigate this further now.

We either need to fix this now or introduce them both at the same time.  I would find this extremely frustrating behavior as a user.  If you can confirm that introducing the job page (even with a dummy) fixes this, i'm fine to keep both reviews in flight and commit ~simultaneously.


> On March 26, 2014, 5:27 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 137
> > <https://reviews.apache.org/r/19565/diff/2/?file=535006#file535006line137>
> >
> >     Can you elaborate?  I'm not sure the TODO has enough context for me to complete it if i wanted to.
> 
> Suman Karumuri wrote:
>     Currently, the schedule is shown as "1 * * * *". Most people don't understand what it means. It would nice if we can show some explanation like "Run this cron job on the first minute of every hour of every day" in a tooltip.

In that case, i vote for removal of the TODO, and possibly opening the discussion in a ticket or IRC.  I think Kevin's data mining of in-use cron schedules may make you reconsider this desire.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38627
-----------------------------------------------------------


On March 26, 2014, 11:01 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 11:01 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38627
-----------------------------------------------------------


I tried this out locally, and the browser back button appears to be broken when i click on a role, then a job.  Does this repro for you?

Also, the arrangement of the title, breadcrumbs, and [Show/Hide Resource Consumption] was changed (the button is directly to the right of the title, which i find odd.


src/main/resources/org/apache/aurora/scheduler/http/ui/error.html
<https://reviews.apache.org/r/19565/#comment70883>

    Still not clear on why there's an error flag and an errorMsg string.  Can the string serve as both?  This allows you to avoid the erroneous conditions of error=true, errorMsg=null, and error=false,errorMsg='Some error'



src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js
<https://reviews.apache.org/r/19565/#comment70884>

    Can you elaborate?  I'm not sure the TODO has enough context for me to complete it if i wanted to.


- Bill Farner


On March 25, 2014, 2:55 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 25, 2014, 2:55 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Suman Karumuri <ma...@apache.org>.


> On March 26, 2014, 11:46 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 65
> > <https://reviews.apache.org/r/19565/diff/2-3/?file=535008#file535008line65>
> >
> >     Are there specific browsers we're stretching for compatibility with here?  If so, calling them out would be helpful for people in the future.

Dropped the comment since it is not apply anymore. 


> On March 26, 2014, 11:46 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 52
> > <https://reviews.apache.org/r/19565/diff/2-3/?file=535008#file535008line52>
> >
> >     Same story as before, why not just use one field if they follow each other?

Did it this way since there is no guarantee that the server will return a non-empty error message and I didn't want to clobber the error message received from the server. Further, keeping the error field separate will also let me pass the error code onto the controller in future, if needed (ex: client is throttled because of too many requests, retry or an authentication error). 


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38677
-----------------------------------------------------------


On March 26, 2014, 11:01 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 11:01 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Bill Farner <wf...@apache.org>.


> On March 26, 2014, 11:46 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 52
> > <https://reviews.apache.org/r/19565/diff/2-3/?file=535008#file535008line52>
> >
> >     Same story as before, why not just use one field if they follow each other?
> 
> Suman Karumuri wrote:
>     Did it this way since there is no guarantee that the server will return a non-empty error message and I didn't want to clobber the error message received from the server. Further, keeping the error field separate will also let me pass the error code onto the controller in future, if needed (ex: client is throttled because of too many requests, retry or an authentication error).

All the more reason to adapt here, it's confusing to present an empty error message to the user.  If you spot one here, you can/should change it to 'No error message returned from the scheduler.'


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38677
-----------------------------------------------------------


On March 27, 2014, 9:04 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 27, 2014, 9:04 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Suman Karumuri <ma...@apache.org>.


> On March 26, 2014, 11:46 p.m., Bill Farner wrote:
> > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 52
> > <https://reviews.apache.org/r/19565/diff/2-3/?file=535008#file535008line52>
> >
> >     Same story as before, why not just use one field if they follow each other?
> 
> Suman Karumuri wrote:
>     Did it this way since there is no guarantee that the server will return a non-empty error message and I didn't want to clobber the error message received from the server. Further, keeping the error field separate will also let me pass the error code onto the controller in future, if needed (ex: client is throttled because of too many requests, retry or an authentication error).
> 
> Bill Farner wrote:
>     All the more reason to adapt here, it's confusing to present an empty error message to the user.  If you spot one here, you can/should change it to 'No error message returned from the scheduler.'

Done.


- Suman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38677
-----------------------------------------------------------


On March 31, 2014, 12:36 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 12:36 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review38677
-----------------------------------------------------------



src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
<https://reviews.apache.org/r/19565/#comment70944>

    Same story as before, why not just use one field if they follow each other?



src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js
<https://reviews.apache.org/r/19565/#comment70945>

    Are there specific browsers we're stretching for compatibility with here?  If so, calling them out would be helpful for people in the future.


- Bill Farner


On March 26, 2014, 11:01 p.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 11:01 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Bill Farner <wf...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/#review39643
-----------------------------------------------------------

Ship it!


Please push to master in concert with https://reviews.apache.org/r/19833/.  As mentioned on the other review, the best approach is probably to branch off master, put this in one commit, and r/19833/ in another.  At that point, push to a non-master branch on origin and ask another teammate to double-check.

- Bill Farner


On March 31, 2014, 12:36 a.m., Suman Karumuri wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19565/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 12:36 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-39
>     https://issues.apache.org/jira/browse/AURORA-39
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implemented the scheduler role and role/env pages using AngularJS.
> 
> Added angular route and underscore.js modules.
> 
> 
> Diffs
> -----
> 
>   3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
>   3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
>   3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
>   src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
>   src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
>   src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 
> 
> Diff: https://reviews.apache.org/r/19565/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build run on local laptop.
> 
> 
> Thanks,
> 
> Suman Karumuri
> 
>

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Suman Karumuri <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/
-----------------------------------------------------------

(Updated March 31, 2014, 12:36 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

Updated error handling per Bill's comments.


Bugs: AURORA-39
    https://issues.apache.org/jira/browse/AURORA-39


Repository: aurora


Description
-------

Implemented the scheduler role and role/env pages using AngularJS.

Added angular route and underscore.js modules.


Diffs (updated)
-----

  3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
  src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
  src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
  src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
  src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
  src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
  src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 

Diff: https://reviews.apache.org/r/19565/diff/


Testing
-------

./gradlew clean build run on local laptop.


Thanks,

Suman Karumuri

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Suman Karumuri <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/
-----------------------------------------------------------

(Updated March 27, 2014, 9:04 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Bugs: AURORA-39
    https://issues.apache.org/jira/browse/AURORA-39


Repository: aurora


Description
-------

Implemented the scheduler role and role/env pages using AngularJS.

Added angular route and underscore.js modules.


Diffs (updated)
-----

  3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
  src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
  src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
  src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
  src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
  src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
  src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 

Diff: https://reviews.apache.org/r/19565/diff/


Testing
-------

./gradlew clean build run on local laptop.


Thanks,

Suman Karumuri

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Suman Karumuri <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/
-----------------------------------------------------------

(Updated March 26, 2014, 11:01 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

Merged error and errorMsg into error.
Cleaned up css a bit for more compact and cleaner UI. Also, made the container fluid so it works better when page resizes.
Previously we were setting the page title on loading the home page only. Fixed it to set page title on role and role/env page also.
Made service.js more dry.


Bugs: AURORA-39
    https://issues.apache.org/jira/browse/AURORA-39


Repository: aurora


Description
-------

Implemented the scheduler role and role/env pages using AngularJS.

Added angular route and underscore.js modules.


Diffs (updated)
-----

  3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
  src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
  src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
  src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css ade850ce624964693e9bd55946464983c4b9f8c2 
  src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
  src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
  src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 

Diff: https://reviews.apache.org/r/19565/diff/


Testing
-------

./gradlew clean build run on local laptop.


Thanks,

Suman Karumuri

Re: Review Request 19565: Role and Role/env pages for Scheduler

Posted by Suman Karumuri <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19565/
-----------------------------------------------------------

(Updated March 25, 2014, 2:55 a.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
-------

refactored quota info into a controller, folded error handling into a directive.
addressed bill's code review comments.


Bugs: AURORA-39
    https://issues.apache.org/jira/browse/AURORA-39


Repository: aurora


Description
-------

Implemented the scheduler role and role/env pages using AngularJS.

Added angular route and underscore.js modules.


Diffs (updated)
-----

  3rdparty/javascript/bower_components/angular-route/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/angular-route.min.js.map PRE-CREATION 
  3rdparty/javascript/bower_components/angular-route/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.editorconfig PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/.gitignore PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/LICENSE PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/README.md PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/bower.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/component.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/package.json PRE-CREATION 
  3rdparty/javascript/bower_components/underscore/underscore.js PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/http/DisplayUtils.java 19df7889f15b4cf44e386d8ce0626cc94fdcdfba 
  src/main/java/org/apache/aurora/scheduler/http/SchedulerzRole.java e2f9ed0ea846c570de11b7dd85bc90aee6bc3342 
  src/main/java/org/apache/aurora/scheduler/http/ServletModule.java e3ff2571d95effcf72b2047cc5840d56143a180c 
  src/main/resources/org/apache/aurora/scheduler/http/schedulerzrole.st b53f3524be052dcd5882c3e79e95e2f90aa071b8 
  src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/error.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/home.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/index.html 36225d1e5147e30ba2cb4ddda96dec9f0f2f1dce 
  src/main/resources/org/apache/aurora/scheduler/http/ui/jobLink.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js db6ea99aeb749fd8674613e3620dc3012872e13c 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 7cd534479dd2f17ffd46248ce9af1f8fe89beb97 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js d2b2017a0efc70d425fd6c89ad6caaf46cb8ded5 
  src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d 
  src/main/resources/org/apache/aurora/scheduler/http/ui/role.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleEnvLink.html PRE-CREATION 
  src/main/resources/org/apache/aurora/scheduler/http/ui/roleLink.html fc25526389749e95efa87c719062dcea88935383 

Diff: https://reviews.apache.org/r/19565/diff/


Testing
-------

./gradlew clean build run on local laptop.


Thanks,

Suman Karumuri