[GitHub] [daffodil] stevedlawrence commented on a change in pull request #696: Ensure we use UTF-8 when outputting and comparing SAX output

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #696:
URL: https://github.com/apache/daffodil/pull/696#discussion_r763994713



##########
File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/DaffodilParseOutputStreamContentHandler.scala
##########
@@ -42,7 +43,7 @@ import org.xml.sax.Locator
  */
 class DaffodilParseOutputStreamContentHandler(out: OutputStream, pretty: Boolean = false)
   extends ContentHandler with Indentable {
-  private val writer = new OutputStreamWriter(out)
+  private val writer = new OutputStreamWriter(out, Charset.forName("UTF-8"))

Review comment:
       I can't find a tool like that, but it really is need. Java allowing encodings to be optional really seems like a mistake, and the fact that it's also allow to be a string makes it even more difficult to find all the locations. I did some greps, but getting a sane number of results to check is difficult. We really need compiler help to find them all. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org