[GitHub] [pulsar] eolivelli commented on a change in pull request #11091: [Transaction] Transaction pending ack lazy init.

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #11091:
URL: https://github.com/apache/pulsar/pull/11091#discussion_r661538840



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java
##########
@@ -101,36 +103,95 @@
 
     private final PersistentSubscription persistentSubscription;
 
-    private final CompletableFuture<PendingAckStore> pendingAckStoreFuture;
+    private CompletableFuture<PendingAckStore> pendingAckStoreFuture;
 
     private final CompletableFuture<PendingAckHandle> pendingAckHandleCompletableFuture = new CompletableFuture<>();
 
+    private final TransactionPendingAckStoreProvider pendingAckStoreProvider;
+
+    private final BlockingQueue<Accept> acceptQueue = new LinkedBlockingDeque<>();
+
+    interface Accept {

Review comment:
       why not "java.lang.Runnable" ?

##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleState.java
##########
@@ -32,14 +32,15 @@
         None,
         Initializing,
         Ready,
+        Error,

Review comment:
       how can we recover from "Error" ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org