You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/04/05 16:32:09 UTC
[GitHub] [camel-website] Siyubu opened a new pull request #321: Camel 14781
security page breadcrumps
Siyubu opened a new pull request #321: Camel 14781 security page breadcrumps
URL: https://github.com/apache/camel-website/pull/321
While navigating on apache website I saw pages that don't have toolbars breadcrumps such as security page from About/ security.
Problem resolution:
From the root repository under layouts/ partials/seo/structured I built a breadcrumbs.html partial which get and display the current page user is on.
The partial has been included in root/security/list.html unde main div.
The purpose of making breadcamps.html a partial is making easy the act of displaying breadcrumps on any camel-website page. what is needed is to include it in the targeted page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #321: Camel 14781
security page breadcrumps
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #321: Camel 14781 security page breadcrumps
URL: https://github.com/apache/camel-website/pull/321#issuecomment-609449318
> There is yarn.lock and yarn-error.log part of this commit. I don't think is right.
I thought putting them in .gitignore was enough. I am going to delete them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart closed pull request #321: Camel 14781
security page breadcrumps
Posted by GitBox <gi...@apache.org>.
zregvart closed pull request #321: Camel 14781 security page breadcrumps
URL: https://github.com/apache/camel-website/pull/321
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Delawen commented on issue #321: Camel 14781
security page breadcrumps
Posted by GitBox <gi...@apache.org>.
Delawen commented on issue #321: Camel 14781 security page breadcrumps
URL: https://github.com/apache/camel-website/pull/321#issuecomment-609609688
So this PR can be closed because we already have #322 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #321: Camel 14781
security page breadcrumps
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #321: Camel 14781 security page breadcrumps
URL: https://github.com/apache/camel-website/pull/321#issuecomment-609444183
While navigating on apache website I saw pages that don't have toolbars breadcrumps such as security page from About/ security.
Problem resolution:
From the root repository under layouts/ partials/seo/structured I built a breadcrumbs.html partial which get and display the current page user is on.
The partial has been included in root/security/list.html unde main div.
The purpose of making breadcamps.html a partial is making easy the act of displaying breadcrumps on any camel-website page. what is needed is to include it in the targeted page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #321: Camel 14781
security page breadcrumps
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #321: Camel 14781 security page breadcrumps
URL: https://github.com/apache/camel-website/pull/321#issuecomment-609449485
> There is yarn.lock and yarn-error.log part of this commit. I don't think is right.
I thought putting them in .gitignore was enough. I am going to delete them
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #321: Camel 14781
security page breadcrumps
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #321: Camel 14781 security page breadcrumps
URL: https://github.com/apache/camel-website/pull/321#issuecomment-609464494
I removed the .yarn.lock and yarn-error.log, pushed and pull a new request.
However I can't find my new request at camel website pull requests and all
5 checks are failing. how may I handle .yarn.lock and yarn-error.log, while
even .gitignore is not helping too.
*Solange Iyubu*
Student
Carnegie Mellon University in Africa
Tel: +250 785 562 715
On Sun, Apr 5, 2020 at 6:35 PM Andrea Cosentino <no...@github.com>
wrote:
> *@oscerd* requested changes on this pull request.
>
> There is yarn.lock and yarn-error.log part of this commit. I don't think
> is right.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/camel-website/pull/321#pullrequestreview-387836765>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALVC76UQ2KJLDQHFCU2YHJLRLCXLVANCNFSM4MBDF6AA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] Siyubu commented on issue #321: Camel 14781
security page breadcrumps
Posted by GitBox <gi...@apache.org>.
Siyubu commented on issue #321: Camel 14781 security page breadcrumps
URL: https://github.com/apache/camel-website/pull/321#issuecomment-609458200
yarn.lock and yarn-error.log removed manually into the repository
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services