[GitHub] [rocketmq] XiaoyiPeng commented on a change in pull request #3795: [ISSUE #3789] optimize: Tag the name of consuming thread whith consumeGroup.

[GitBox <gi...@apache.org>]

XiaoyiPeng commented on a change in pull request #3795:
URL: https://github.com/apache/rocketmq/pull/3795#discussion_r792298498



##########
File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/ConsumeMessageConcurrentlyService.java
##########
@@ -70,13 +70,19 @@ public ConsumeMessageConcurrentlyService(DefaultMQPushConsumerImpl defaultMQPush
         this.consumerGroup = this.defaultMQPushConsumer.getConsumerGroup();
         this.consumeRequestQueue = new LinkedBlockingQueue<Runnable>();
 
+        String consumeThreadPrefix = null;
+        if (consumerGroup.length() > 100) {

Review comment:
       Thanks for your review.
   
   1. The maximum length of a `topic` name is **127**. The business-side naming `consumeGroup` usually contains some or all of the information for the `topic name`, so this length value 100 maybe relatively reasonable.
   2. In addition, although the maximum length of a `topic` name is **127**, in the actual business, users may not take such a long name. Similarly, the naming of consumer groups is also the same.
   3. You can type 100 characters into your text editor and it doesn't look so bad.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org