[GitHub] [doris] 924060929 commented on a diff in pull request #15671: [feature](Nereids) Support lots of aggregate functions

[GitBox <gi...@apache.org>]

924060929 commented on code in PR #15671:
URL: https://github.com/apache/doris/pull/15671#discussion_r1064456325


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -1551,4 +1559,21 @@ public DataType visitPrimitiveDataType(PrimitiveDataTypeContext ctx) {
         ctx.INTEGER_VALUE().stream().map(ParseTree::getText).forEach(l::add);
         return DataType.convertPrimitiveFromStrings(l);
     }
+
+    private Expression parseFunctionWithOrderKeys(String functionName, boolean isDistinct,

Review Comment:
   currently we only support the group_concat, we can consider generality if more function need order by



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org