You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commons-dev@ws.apache.org by "Rich Scheuerle (JIRA)" <ji...@apache.org> on 2008/03/19 00:40:24 UTC

[jira] Created: (WSCOMMONS-313) OMOutputFormat: If doingSWA and doOptimize are both set, prefer doOptimize

OMOutputFormat: If doingSWA and doOptimize are both set, prefer doOptimize
--------------------------------------------------------------------------

                 Key: WSCOMMONS-313
                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
             Project: WS-Commons
          Issue Type: Bug
          Components: AXIOM
            Reporter: Rich Scheuerle
            Assignee: Rich Scheuerle


Scenario:
OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  

Solution:
Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Updated: (WSCOMMONS-313) OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Scheuerle updated WSCOMMONS-313:
-------------------------------------

    Summary: OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold  (was: OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we nee doOptimizeThreshold)

> OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold
> ----------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Updated: (WSCOMMONS-313) OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold

Posted by "Nikhil Thaker (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nikhil Thaker updated WSCOMMONS-313:
------------------------------------

    Attachment: threahold.txt

Attached is the patch for this JIRA. I have introduced new optimizedThreshold value on OMOutputFormat, the value of that variable will be used to see if we want to inline or optimize the attachments. Decision for this is made in MTOMXMLStreamReader.

> OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold
> ----------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Nikhil Thaker
>         Attachments: threahold.txt
>
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Commented: (WSCOMMONS-313) OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold

Posted by "Thilina Gunarathne (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12583049#action_12583049 ] 

Thilina Gunarathne commented on WSCOMMONS-313:
----------------------------------------------

Hi Rich,
Necessary Axis2  parts have been written to give priority to the MTOM in case both "enableMTOM" and "enableSwA" are being set to true..  

IIRC we did not worry about resolving it in OMOutputFormat as we assumed it to be already resolved in Axis2 level..  My first preference would be throwing of IllegalArgumentException due to the above assumption.. If it's hard then, I would propose to prefer MTOM if both are set, just to be consistent with Axis2 behavior..

thanks,
Thilina

> OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold
> ----------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Assigned: (WSCOMMONS-313) OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Scheuerle reassigned WSCOMMONS-313:
----------------------------------------

    Assignee: Nikhil Thaker  (was: Rich Scheuerle)

> OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold
> ----------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Nikhil Thaker
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Work started: (WSCOMMONS-313) OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold

Posted by "Nikhil Thaker (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Work on WSCOMMONS-313 started by Nikhil Thaker.

> OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold
> ----------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Nikhil Thaker
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Updated: (WSCOMMONS-313) OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen updated WSCOMMONS-313:
--------------------------------------

    Fix Version/s: Axiom 1.2.9

> OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold
> ----------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>             Fix For: Axiom 1.2.9
>
>         Attachments: threahold.txt
>
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WSCOMMONS-313) OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen updated WSCOMMONS-313:
--------------------------------------

    Fix Version/s: Axiom 1.2.10
                       (was: Axiom 1.2.9)

> OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold
> ----------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>             Fix For: Axiom 1.2.10
>
>         Attachments: threahold.txt
>
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WSCOMMONS-313) OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold

Posted by "Davanum Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Davanum Srinivas resolved WSCOMMONS-313.
----------------------------------------

    Resolution: Fixed

Looks like Nikhil took care of this one.

thanks,
dims

> OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold
> ----------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Nikhil Thaker
>         Attachments: threahold.txt
>
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Reopened: (WSCOMMONS-313) OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Scheuerle reopened WSCOMMONS-313:
--------------------------------------

      Assignee: Rich Scheuerle  (was: Nikhil Thaker)

Reopening.  The mutually exclusive change still needs to be investigated.

> OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we need doOptimizeThreshold
> ----------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>         Attachments: threahold.txt
>
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Commented: (WSCOMMONS-313) OMOutputFormat: If doingSWA and doOptimize are both set, prefer doOptimize

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582684#action_12582684 ] 

Rich Scheuerle commented on WSCOMMONS-313:
------------------------------------------

Hey Glen,

I agree.  But that will take a bigger coding effort.  I will leave the defect open for now to investigate.

In the near future we need to update OMOutputFormat to do a "optimizeThreshold" to support JAXWS @MTOM(threshhold=..).
That would be a good time to tackle this issue with doingSWA and doOptimize.

Thanks,
Rich



> OMOutputFormat: If doingSWA and doOptimize are both set, prefer doOptimize
> --------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Commented: (WSCOMMONS-313) OMOutputFormat: If doingSWA and doOptimize are both set, prefer doOptimize

Posted by "Glen Daniels (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580334#action_12580334 ] 

Glen Daniels commented on WSCOMMONS-313:
----------------------------------------

What about throwing an IllegalArgumentException if you try to set one when the other's already set?

> OMOutputFormat: If doingSWA and doOptimize are both set, prefer doOptimize
> --------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org


[jira] Updated: (WSCOMMONS-313) OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we nee doOptimizeThreshold

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WSCOMMONS-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Scheuerle updated WSCOMMONS-313:
-------------------------------------

    Summary: OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we nee doOptimizeThreshold  (was: OMOutputFormat: If doingSWA and doOptimize are both set, prefer doOptimize)

> OMOutputFormat: doSWA and doOptimize should be mutually exclusive...plus we nee doOptimizeThreshold
> ---------------------------------------------------------------------------------------------------
>
>                 Key: WSCOMMONS-313
>                 URL: https://issues.apache.org/jira/browse/WSCOMMONS-313
>             Project: WS-Commons
>          Issue Type: Bug
>          Components: AXIOM
>            Reporter: Rich Scheuerle
>            Assignee: Rich Scheuerle
>
> Scenario:
> OMOutputFormat is set with both doingSWA and doOptimize.  In such cases, both cannot be satisifed.  
> Solution:
> Prefer doingSWA if both are set.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: commons-dev-help@ws.apache.org