You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by Christopher <ct...@apache.org> on 2015/05/11 23:35:32 UTC

Surprise DEPENDENCIES file from a maven plugin

Hi all,

I'm trying to figure out where this extra DEPENDENCIES file is coming
from in the root of my source-release tarball using the latest ASF
parent POM (org.apache:apache:pom:17) during a release.

This file seems to fail the apache-rat check, and makes the
-source-release.tar.gz fail to match the SHA-1 git commit.

Our project (Apache Accumulo) used to override the
maven-assembly-plugin execution in the apache-release profile and
build at the "validate" phase of the build lifecyle, but now we're
deferring to the parent POM, which executes this assembly at the
"package" phase. Some plugin appears to be modifying the source
directory by adding this DEPENDENCIES file (which is empty, except for
its header, because the root of our project doesn't have any
dependencies) before the "package" phase, but I'm not sure which one.

Has anybody seen this? Perhaps in another ASF project which depends on
the ASF parent POM?

--
Christopher L Tubbs II
http://gravatar.com/ctubbsii

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: Surprise DEPENDENCIES file from a maven plugin

Posted by Christopher <ct...@apache.org>.
For what it's worth, I found a workaround: add my own DEPENDENCIES
file to SCM. The remote-resources plugin doesn't appear to clobber
existing files.

--
Christopher L Tubbs II
http://gravatar.com/ctubbsii


On Tue, May 12, 2015 at 11:04 AM, Christopher <ct...@apache.org> wrote:
> On Tue, May 12, 2015 at 1:38 AM, Karl Heinz Marbaise <kh...@gmx.de> wrote:
>> Hi Christopher,
>>
>> the DEPENDENCIES file is generated by the maven-remote-resources-plugin
>>
>> http://svn.apache.org/viewvc/maven/pom/tags/apache-17/pom.xml?view=markup
>>
>> Lines 308-323 ...
>>
>
> Thanks. It seems (to me) like this might be a bug with
> maven-remote-resources-plugin... this file seems to only exist in the
> root of the project (which is our  intermediate parent POM), and seems
> to generate an empty file (except for the header), because our
> project's parent POM has no dependencies. It's a completely worthless
> file. It does not get added to any of the child modules, where it
> might actually be useful (because they actually have dependencies).
>
> Further, it seems like a bug because plugins shouldn't really be
> modifying stuff outside of ${project.build.directory} usually. Does
> anybody know the history of this behavior, and what this file's
> purpose is?
>
> [snip]
>> On 5/11/15 11:35 PM, Christopher wrote:
> [snip]
>>> This file seems to fail the apache-rat check, and makes the
>>> -source-release.tar.gz fail to match the SHA-1 git commit.
>>
>>
>> I see fialing the apache-rat check but the SHA-1 git commit i don't
>> understand ?
>>
> [snip]
>
> I mean: the -source-release.tar.gz includes this file, but the release
> tag in git does not. Thus, our official source release tarball does
> not match any actual tag in SCM, which is unexpected.
>
> Another problem is that adding this file "dirties" the clean checkout
> of the tag during "release:perform", and as a result, a plugin we have
> configured to insert the git commit id (SHA-1) into the MANIFEST.MF
> files for the "Implementation Build" gets marked with a "-dirty"
> suffix, to indicate the release build was modified since checkout from
> the tag (which is normally a bad thing).

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: Surprise DEPENDENCIES file from a maven plugin

Posted by Christopher <ct...@apache.org>.
On Tue, May 12, 2015 at 1:38 AM, Karl Heinz Marbaise <kh...@gmx.de> wrote:
> Hi Christopher,
>
> the DEPENDENCIES file is generated by the maven-remote-resources-plugin
>
> http://svn.apache.org/viewvc/maven/pom/tags/apache-17/pom.xml?view=markup
>
> Lines 308-323 ...
>

Thanks. It seems (to me) like this might be a bug with
maven-remote-resources-plugin... this file seems to only exist in the
root of the project (which is our  intermediate parent POM), and seems
to generate an empty file (except for the header), because our
project's parent POM has no dependencies. It's a completely worthless
file. It does not get added to any of the child modules, where it
might actually be useful (because they actually have dependencies).

Further, it seems like a bug because plugins shouldn't really be
modifying stuff outside of ${project.build.directory} usually. Does
anybody know the history of this behavior, and what this file's
purpose is?

[snip]
> On 5/11/15 11:35 PM, Christopher wrote:
[snip]
>> This file seems to fail the apache-rat check, and makes the
>> -source-release.tar.gz fail to match the SHA-1 git commit.
>
>
> I see fialing the apache-rat check but the SHA-1 git commit i don't
> understand ?
>
[snip]

I mean: the -source-release.tar.gz includes this file, but the release
tag in git does not. Thus, our official source release tarball does
not match any actual tag in SCM, which is unexpected.

Another problem is that adding this file "dirties" the clean checkout
of the tag during "release:perform", and as a result, a plugin we have
configured to insert the git commit id (SHA-1) into the MANIFEST.MF
files for the "Implementation Build" gets marked with a "-dirty"
suffix, to indicate the release build was modified since checkout from
the tag (which is normally a bad thing).

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: Surprise DEPENDENCIES file from a maven plugin

Posted by Karl Heinz Marbaise <kh...@gmx.de>.
Hi Christopher,

the DEPENDENCIES file is generated by the maven-remote-resources-plugin

http://svn.apache.org/viewvc/maven/pom/tags/apache-17/pom.xml?view=markup

Lines 308-323 ...

We have in our parent a special exclusion for the apache-rat-plugin

http://svn.apache.org/viewvc/maven/pom/tags/maven-parent-26/pom.xml?view=markup

Lines 979-1002

The handling of the DEPENDENCIES files is already addresses to the 
apache-rat team via  https://issues.apache.org/jira/browse/RAT-184

This means in other words that you have to add the configuration for the 
apache-rat-plugin into your project until the RAT-184 has been solved by 
a new release (RAT 0.12)...

and a new ASF release which will be done until the new release of 
apache-rat is out...


On 5/11/15 11:35 PM, Christopher wrote:
> Hi all,
>
> I'm trying to figure out where this extra DEPENDENCIES file is coming
> from in the root of my source-release tarball using the latest ASF
> parent POM (org.apache:apache:pom:17) during a release.
>
> This file seems to fail the apache-rat check, and makes the
> -source-release.tar.gz fail to match the SHA-1 git commit.

I see fialing the apache-rat check but the SHA-1 git commit i don't 
understand ?


>
> Our project (Apache Accumulo) used to override the
> maven-assembly-plugin execution in the apache-release profile and
> build at the "validate" phase of the build lifecyle, but now we're
> deferring to the parent POM, which executes this assembly at the
> "package" phase. Some plugin appears to be modifying the source
> directory by adding this DEPENDENCIES file (which is empty, except for
> its header, because the root of our project doesn't have any
> dependencies) before the "package" phase, but I'm not sure which one.
>
> Has anybody seen this? Perhaps in another ASF project which depends on
> the ASF parent POM?
>
> --
> Christopher L Tubbs II
> http://gravatar.com/ctubbsii
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>


Kind regards
Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org