You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@horaedb.apache.org by "dracoooooo (via GitHub)" <gi...@apache.org> on 2024/05/29 15:15:48 UTC
[PR] feat: support INSERT INTO SELECT [incubator-horaedb]
dracoooooo opened a new pull request, #1536:
URL: https://github.com/apache/incubator-horaedb/pull/1536
Close #557
## Rationale
INSERT INTO SELECT is useful to migrate table, benchmark(to quickly generate lots of data).
## Detailed Changes
When generating the insert logical plan, alse generate the select logical plan and store it in the insert plan. Then execute the select logical plan in the insert interpreter, convert the result records into RowGroup and then insert it.
## Test Plan
integration test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org
Re: [PR] feat: support INSERT INTO SELECT [incubator-horaedb]
Posted by "dracoooooo (via GitHub)" <gi...@apache.org>.
dracoooooo commented on PR #1536:
URL: https://github.com/apache/incubator-horaedb/pull/1536#issuecomment-2143809003
> @dracoooooo Hi, it seems there are some CI errors, would you mind take a look?
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org
Re: [PR] feat: support INSERT INTO SELECT [horaedb]
Posted by "jiacai2050 (via GitHub)" <gi...@apache.org>.
jiacai2050 commented on code in PR #1536:
URL: https://github.com/apache/horaedb/pull/1536#discussion_r1670061902
##########
integration_tests/cases/common/dml/insert_into_select.result:
##########
Review Comment:
As said in https://github.com/apache/horaedb/issues/1538#issuecomment-2216948573, sql with multiple tables may fails, so currently we can only enable this features in standalone mode.
In cluster mode, we can do a check to ensure tables belonging to same instance.
For now, you can move this test under local dir, something like `integration_tests/cases/env/local/dml/insert_into_select.sql`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org
Re: [PR] feat: support INSERT INTO SELECT [incubator-horaedb]
Posted by "jiacai2050 (via GitHub)" <gi...@apache.org>.
jiacai2050 commented on PR #1536:
URL: https://github.com/apache/incubator-horaedb/pull/1536#issuecomment-2138577107
@dracoooooo Hi, it seems there are some CI errors, would you mind take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org
Re: [PR] feat: support INSERT INTO SELECT [horaedb]
Posted by "jiacai2050 (via GitHub)" <gi...@apache.org>.
jiacai2050 merged PR #1536:
URL: https://github.com/apache/horaedb/pull/1536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@horaedb.apache.org
For additional commands, e-mail: commits-help@horaedb.apache.org