You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Tsuyoshi Ozawa (JIRA)" <ji...@apache.org> on 2015/04/17 13:30:59 UTC

[jira] [Commented] (YARN-3181) FairScheduler: Fix up outdated findbugs issues

    [ https://issues.apache.org/jira/browse/YARN-3181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14499667#comment-14499667 ] 

Tsuyoshi Ozawa commented on YARN-3181:
--------------------------------------

I agree with Karthik's comment - this is not urgent concern. In fact, findbugs-exclude.xml is not outdated since FairScheduler does some optimization which findbugs warns for getting better concurrency. On this JIRA, we should check the order of lock very carefully without degrading performance. As a result, it would be better we can remove  IS2_INCONSISTENT_SYNC exclusion from findbugs-exclude file.

> FairScheduler: Fix up outdated findbugs issues
> ----------------------------------------------
>
>                 Key: YARN-3181
>                 URL: https://issues.apache.org/jira/browse/YARN-3181
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.6.0
>            Reporter: Karthik Kambatla
>            Assignee: Brahma Reddy Battula
>         Attachments: YARN-3181-002.patch, yarn-3181-1.patch
>
>
> In FairScheduler, we have excluded some findbugs-reported errors. Some of them aren't applicable anymore, and there are a few that can be easily fixed without needing an exclusion. It would be nice to fix them. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)