[GitHub] jayapalu commented on a change in pull request #2113: CLOUDSTACK-9162: Handled vpn user add when vpn is not enabled on the?

[gi...@git.apache.org]

jayapalu commented on a change in pull request #2113:  CLOUDSTACK-9162: Handled vpn user add when vpn is not enabled on the?
URL: https://github.com/apache/cloudstack/pull/2113#discussion_r118900321
 
 

 ##########
 File path: api/src/org/apache/cloudstack/api/command/user/vpn/AddVpnUserCmd.java
 ##########
 @@ -124,7 +124,7 @@ public void execute() {
                 throw new ServerApiException(ApiErrorCode.INTERNAL_ERROR, "Failed to add vpn user");
             }
         }catch (Exception ex) {
 
 Review comment:
   Here two cases there.
   1. apply vpn user failed and returned false. then we throw exception at line 124.
   2. apply vpn user got thrown an exception then it is catches.  
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services