You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Vikram Dixit Kumaraswamy <vi...@gmail.com> on 2013/10/01 03:38:45 UTC
Review Request 14425: HIVE-5403: Move loading of filesystem, ugi,
metastore client to hive session
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14425/
-----------------------------------------------------------
Review request for hive and Gunther Hagleitner.
Bugs: HIVE-5403
https://issues.apache.org/jira/browse/HIVE-5403
Repository: hive-git
Description
-------
Move loading of filesystem, ugi, metastore client to hive session.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 0491f8b
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java f6b1491
Diff: https://reviews.apache.org/r/14425/diff/
Testing
-------
Does not affect any unit tests but all of them exercise this code path.
Thanks,
Vikram Dixit Kumaraswamy
Re: Review Request 14425: HIVE-5403: Move loading of filesystem, ugi,
metastore client to hive session
Posted by Vikram Dixit Kumaraswamy <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14425/
-----------------------------------------------------------
(Updated Oct. 1, 2013, 9:04 p.m.)
Review request for hive and Gunther Hagleitner.
Changes
-------
Addressed Gunther's comments.
Bugs: HIVE-5403
https://issues.apache.org/jira/browse/HIVE-5403
Repository: hive-git
Description
-------
Move loading of filesystem, ugi, metastore client to hive session.
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 0491f8b
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java f6b1491
Diff: https://reviews.apache.org/r/14425/diff/
Testing
-------
Does not affect any unit tests but all of them exercise this code path.
Thanks,
Vikram Dixit Kumaraswamy
Re: Review Request 14425: HIVE-5403: Move loading of filesystem, ugi,
metastore client to hive session
Posted by Gunther Hagleitner <gh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14425/#review26542
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
<https://reviews.apache.org/r/14425/#comment51790>
instead of putting this comment there... why not add a public method to load/create the meta store client. that one can be used by anyone. (maybe just change the visibility of createMetaStoreClient)
- Gunther Hagleitner
On Oct. 1, 2013, 1:38 a.m., Vikram Dixit Kumaraswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14425/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2013, 1:38 a.m.)
>
>
> Review request for hive and Gunther Hagleitner.
>
>
> Bugs: HIVE-5403
> https://issues.apache.org/jira/browse/HIVE-5403
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Move loading of filesystem, ugi, metastore client to hive session.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 0491f8b
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java f6b1491
>
> Diff: https://reviews.apache.org/r/14425/diff/
>
>
> Testing
> -------
>
> Does not affect any unit tests but all of them exercise this code path.
>
>
> Thanks,
>
> Vikram Dixit Kumaraswamy
>
>