You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/03/19 23:39:29 UTC
[kudu-CR] compaction-test: use default bloom sizing
Hello David Ribeiro Alves, Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6429
to review the following change.
Change subject: compaction-test: use default bloom sizing
......................................................................
compaction-test: use default bloom sizing
To make this test more realistic, use the default bloom filter size,
which has some optimizations to avoid slow 'div' instructions.
Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362
---
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
3 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/6429/1
--
To view, visit http://gerrit.cloudera.org:8080/6429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
[kudu-CR] compaction-test: use default bloom sizing
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: compaction-test: use default bloom sizing
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6429/2/src/kudu/tablet/compaction-test.cc
File src/kudu/tablet/compaction-test.cc:
PS2, Line 492: EXPECT_EQ(R"(RowIdxInBlock: 0; Base: (string key="hello 00017150", int32 val=1715, )"
: "int32 nullable_val=NULL); Undo Mutations: [@1716(DELETE)]; Redo Mutations: [];",
: rows[0]);
: EXPECT_EQ(R"(RowIdxInBlock: 1; Base: (string key="hello 00017160", int32 val=1716, )"
: "int32 nullable_val=1716); Undo Mutations: [@1717(DELETE)]; Redo Mutations: [];",
: rows[1]);
> Can we compute the expected strings instead of hardcoding them?
With different bloom sizing, the rolling writer rolled at slightly different times (more smaller bloom blocks = more index overhead in the files, plus a lower FP rate = more bits/entry, etc, triggering a roll earlier).
I don't think there's any real way to avoid hardcoding these, since the number of variables is very large.
http://gerrit.cloudera.org:8080/#/c/6429/2/src/kudu/tablet/tablet.h
File src/kudu/tablet/tablet.h:
PS2, Line 393: static BloomFilterSizing DefaultBloomSizing();
> docs
Done
--
To view, visit http://gerrit.cloudera.org:8080/6429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] compaction-test: use default bloom sizing
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: compaction-test: use default bloom sizing
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6429/2/src/kudu/tablet/compaction-test.cc
File src/kudu/tablet/compaction-test.cc:
PS2, Line 492: EXPECT_EQ(R"(RowIdxInBlock: 0; Base: (string key="hello 00017150", int32 val=1715, )"
: "int32 nullable_val=NULL); Undo Mutations: [@1716(DELETE)]; Redo Mutations: [];",
: rows[0]);
: EXPECT_EQ(R"(RowIdxInBlock: 1; Base: (string key="hello 00017160", int32 val=1716, )"
: "int32 nullable_val=1716); Undo Mutations: [@1717(DELETE)]; Redo Mutations: [];",
: rows[1]);
I don't fully understand why this changed. why was that?
http://gerrit.cloudera.org:8080/#/c/6429/2/src/kudu/tablet/tablet.h
File src/kudu/tablet/tablet.h:
PS2, Line 393: static BloomFilterSizing DefaultBloomSizing();
docs
--
To view, visit http://gerrit.cloudera.org:8080/6429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] compaction-test: use default bloom sizing
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6429
to look at the new patch set (#3).
Change subject: compaction-test: use default bloom sizing
......................................................................
compaction-test: use default bloom sizing
To make this test more realistic, use the default bloom filter size,
which has some optimizations to avoid slow 'div' instructions.
Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362
---
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
3 files changed, 11 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/6429/3
--
To view, visit http://gerrit.cloudera.org:8080/6429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] compaction-test: use default bloom sizing
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change.
Change subject: compaction-test: use default bloom sizing
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6429/2/src/kudu/tablet/compaction-test.cc
File src/kudu/tablet/compaction-test.cc:
PS2, Line 492: EXPECT_EQ(R"(RowIdxInBlock: 0; Base: (string key="hello 00017150", int32 val=1715, )"
: "int32 nullable_val=NULL); Undo Mutations: [@1716(DELETE)]; Redo Mutations: [];",
: rows[0]);
: EXPECT_EQ(R"(RowIdxInBlock: 1; Base: (string key="hello 00017160", int32 val=1716, )"
: "int32 nullable_val=1716); Undo Mutations: [@1717(DELETE)]; Redo Mutations: [];",
: rows[1]);
> I don't fully understand why this changed. why was that?
Can we compute the expected strings instead of hardcoding them?
--
To view, visit http://gerrit.cloudera.org:8080/6429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] compaction-test: use default bloom sizing
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: compaction-test: use default bloom sizing
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] compaction-test: use default bloom sizing
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6429
to look at the new patch set (#2).
Change subject: compaction-test: use default bloom sizing
......................................................................
compaction-test: use default bloom sizing
To make this test more realistic, use the default bloom filter size,
which has some optimizations to avoid slow 'div' instructions.
Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362
---
M src/kudu/tablet/compaction-test.cc
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet.h
3 files changed, 10 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/6429/2
--
To view, visit http://gerrit.cloudera.org:8080/6429
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id80e4a9dd693f0eb41e09f037f2ad72790ae1362
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Andrew Wong <an...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins