You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/11/06 18:12:42 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request, #341: omega-edit updates
Shanedell opened a new pull request, #341:
URL: https://github.com/apache/daffodil-vscode/pull/341
omega-edit updates:
- Use version 0.9.24.
- Use omega-edit replace function instead of using work around.
- omega-edit added a NOTICE so removed it from NONOTICE and added it to the release NOTICE file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #341: omega-edit updates
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #341:
URL: https://github.com/apache/daffodil-vscode/pull/341#discussion_r1015562603
##########
build/package/NOTICE:
##########
@@ -280,3 +280,18 @@ The following NOTICE information applies to binary components distributed with t
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+- 'omega-edit' in extension/dist/ext/extension.js
+ Copyright 2021 Concurrent Technologies Corporation.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
Review Comment:
@stevedlawrence Is this good to merge and I can make an update to the NOTICE for `omega-edit` if its `NOTICE` file is updated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #341: omega-edit updates
Posted by GitBox <gi...@apache.org>.
Shanedell merged PR #341:
URL: https://github.com/apache/daffodil-vscode/pull/341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on a diff in pull request #341: omega-edit updates
Posted by GitBox <gi...@apache.org>.
Shanedell commented on code in PR #341:
URL: https://github.com/apache/daffodil-vscode/pull/341#discussion_r1015426305
##########
build/package/NOTICE:
##########
@@ -280,3 +280,18 @@ The following NOTICE information applies to binary components distributed with t
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+- 'omega-edit' in extension/dist/ext/extension.js
+ Copyright 2021 Concurrent Technologies Corporation.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
Review Comment:
Tagging @scholarsmate so he sees this comment about the NOTICE file for omega-edit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #341: omega-edit updates
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #341:
URL: https://github.com/apache/daffodil-vscode/pull/341#discussion_r1015576704
##########
build/package/NOTICE:
##########
@@ -280,3 +280,18 @@ The following NOTICE information applies to binary components distributed with t
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+- 'omega-edit' in extension/dist/ext/extension.js
+ Copyright 2021 Concurrent Technologies Corporation.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
Review Comment:
Yep, this is good to merge for the 0.9.24 version of omega-edit. If omega-edit changes the NOTICE in a later release then we can update our NOTICE/NONOTICE files as needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #341: omega-edit updates
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #341:
URL: https://github.com/apache/daffodil-vscode/pull/341#discussion_r1015373551
##########
build/package/NOTICE:
##########
@@ -280,3 +280,18 @@ The following NOTICE information applies to binary components distributed with t
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
+
+- 'omega-edit' in extension/dist/ext/extension.js
+ Copyright 2021 Concurrent Technologies Corporation.
+
+ Licensed under the Apache License, Version 2.0 (the "License");
Review Comment:
This is correct since this is what's in omega-edit's NOTICE file, but in case omega-edit devs see this, the ASF recommends to not put the license in the NOTICE file (that's what the LICENSE is for). This file usually about copyright information, code origins, and third-party NOTICES.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org