[GitHub] spark pull request #13413: [SPARK-15663][SQL] SparkSession.catalog.listFunct...

[maropu <gi...@git.apache.org>]

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13413#discussion_r65796505
  
    --- Diff: python/pyspark/sql/tests.py ---
    @@ -1481,17 +1481,7 @@ def test_list_functions(self):
             spark.sql("CREATE DATABASE some_db")
             functions = dict((f.name, f) for f in spark.catalog.listFunctions())
             functionsDefault = dict((f.name, f) for f in spark.catalog.listFunctions("default"))
    -        self.assertTrue(len(functions) > 200)
    -        self.assertTrue("+" in functions)
    -        self.assertTrue("like" in functions)
    -        self.assertTrue("month" in functions)
    -        self.assertTrue("to_unix_timestamp" in functions)
    -        self.assertTrue("current_database" in functions)
    -        self.assertEquals(functions["+"], Function(
    -            name="+",
    -            description=None,
    -            className="org.apache.spark.sql.catalyst.expressions.Add",
    -            isTemporary=True))
    +        self.assertEquals(len(functions), 0)
    --- End diff --
    
    Seems we need some units tests to check if we could show user-defined temp functions in `listFunctions`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org