[GitHub] spark pull request: [SPARK-15515] [SQL] Error Handling in Running SQL Direct...

[zsxwing <gi...@git.apache.org>]

Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13283#discussion_r65276227
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala ---
    @@ -38,6 +38,10 @@ private[sql] class ResolveDataSource(sparkSession: SparkSession) extends Rule[Lo
               sparkSession,
               paths = u.tableIdentifier.table :: Nil,
               className = u.tableIdentifier.database.get)
    +        if (dataSource.isFileFormat() == Option(false)) {
    --- End diff --
    
    `isFileFormat` is not necessary. You can use `providingClass` like this:
    
    ```Scala
            val notSupportDirectQuery = try {
              !classOf[FileFormat].isAssignableFrom(dataSource.providingClass)
            } catch {
              case NonFatal(e) => false
            }
            if (notSupportDirectQuery) {
              throw new AnalysisException("Unsupported data source type for direct query on files: " +
                s"${u.tableIdentifier.database.get}")
            }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org