You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucenenet.apache.org by ni...@apache.org on 2022/03/03 12:56:14 UTC

[lucenenet] branch master updated: PERFORMANCE: Lucene.Net.Index.BaseCompositeReader: Removed unnecessary list allocation

This is an automated email from the ASF dual-hosted git repository.

nightowl888 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucenenet.git


The following commit(s) were added to refs/heads/master by this push:
     new 50dd72e  PERFORMANCE: Lucene.Net.Index.BaseCompositeReader: Removed unnecessary list allocation
50dd72e is described below

commit 50dd72e23dcd0f2bad639ed164bc4a308cb9500c
Author: Shad Storhaug <sh...@shadstorhaug.com>
AuthorDate: Mon Feb 14 21:30:17 2022 +0700

    PERFORMANCE: Lucene.Net.Index.BaseCompositeReader: Removed unnecessary list allocation
---
 src/Lucene.Net/Index/BaseCompositeReader.cs | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/src/Lucene.Net/Index/BaseCompositeReader.cs b/src/Lucene.Net/Index/BaseCompositeReader.cs
index b6e5a0e..3bcdb1c 100644
--- a/src/Lucene.Net/Index/BaseCompositeReader.cs
+++ b/src/Lucene.Net/Index/BaseCompositeReader.cs
@@ -1,7 +1,6 @@
 using J2N.Collections.Generic.Extensions;
 using System;
 using System.Collections.Generic;
-using JCG = J2N.Collections.Generic;
 
 namespace Lucene.Net.Index
 {
@@ -72,13 +71,7 @@ namespace Lucene.Net.Index
         protected BaseCompositeReader(R[] subReaders)
         {
             this.subReaders = subReaders;
-
-            // LUCENENET: To eliminate casting, we create the list explicitly
-            var subReadersList = new JCG.List<IndexReader>(subReaders.Length);
-            for (int i = 0; i < subReaders.Length; i++)
-                subReadersList.Add(subReaders[i]);
-            this.subReadersList = subReadersList.AsReadOnly();
-
+            this.subReadersList = ((IndexReader[])subReaders).AsReadOnly(); // LUCENENET: Work around generic casting from R to IndexWriter
             starts = new int[subReaders.Length + 1]; // build starts array
             int maxDoc = 0, numDocs = 0;
             for (int i = 0; i < subReaders.Length; i++)