You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/01/26 20:29:12 UTC
Review Request 55995: Restored quota correctly during allocator
recovery.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55995/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
Bugs: MESOS-7008
https://issues.apache.org/jira/browse/MESOS-7008
Repository: mesos
Description
-------
The previous coding neglected to restore the quota during allocator
recovery if the expected agent count is zero.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp c2211be7458755aeb91ef078e4bfe92ac474044a
src/tests/master_quota_tests.cpp 54ae66f09a0b9d1e3be0c44bd4a8bbf5d27ba688
Diff: https://reviews.apache.org/r/55995/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 55995: Restored quota correctly during allocator
recovery.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55995/#review163201
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55995]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 26, 2017, 8:29 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55995/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 8:29 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Bugs: MESOS-7008
> https://issues.apache.org/jira/browse/MESOS-7008
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The previous coding neglected to restore the quota during allocator
> recovery if the expected agent count is zero.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp c2211be7458755aeb91ef078e4bfe92ac474044a
> src/tests/master_quota_tests.cpp 54ae66f09a0b9d1e3be0c44bd4a8bbf5d27ba688
>
> Diff: https://reviews.apache.org/r/55995/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 55995: Restored quota correctly during allocator
recovery.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55995/#review163897
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Jan. 26, 2017, 8:29 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55995/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 8:29 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Benjamin Bannier.
>
>
> Bugs: MESOS-7008
> https://issues.apache.org/jira/browse/MESOS-7008
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The previous coding neglected to restore the quota during allocator
> recovery if the expected agent count is zero.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp c2211be7458755aeb91ef078e4bfe92ac474044a
> src/tests/master_quota_tests.cpp 54ae66f09a0b9d1e3be0c44bd4a8bbf5d27ba688
>
> Diff: https://reviews.apache.org/r/55995/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>