[jira] [Commented] (YETUS-315) smart-apply-patch committer mode should support signed commits

["Allen Wittenauer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YETUS-315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014877#comment-16014877 ] 

Allen Wittenauer commented on YETUS-315:
----------------------------------------

Hi. Playing catch-up.

Maybe if I talk about my personal workflow it will help?

Typically, I'll get a patch, do a quick once over, and then use smart-apply-patch in non-committer mode to test it out.  After I'm finished vetting it, I'll then hop over to my ASF directory, run s-a-p in --committer mode, and then do a git push.  My hope was that --committer would be "one stop shopping".

I'm starting to think this may have been naïve and/or too optimistic.

So what if we make "--committer" a bit like "--jenkins" in test-patch?  It effectively becomes a macro for what we "recommend" as the default state, but individuals can selectively pick their feature set via specific command line flags.  If someone picks --committer and one of those states fails (not git-am compatible, no GPG, whatever), we fail passing along git's message.

Thoughts?

> smart-apply-patch committer mode should support signed commits
> --------------------------------------------------------------
>
>                 Key: YETUS-315
>                 URL: https://issues.apache.org/jira/browse/YETUS-315
>             Project: Yetus
>          Issue Type: New Feature
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Suraj Acharya
>             Fix For: 0.5.0
>
>
> A new {{--gpg-sign}} flag is added to the smart-apply-patch.sh.
> This will allow the committer to sign the commit.
> GPG Agent will handle the passphrase request.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)