[GitHub] [iceberg] rdblue commented on a change in pull request #4024: Spark: Allow create table in hadoop catalog root namespace

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #4024:
URL: https://github.com/apache/iceberg/pull/4024#discussion_r797816096



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -567,6 +571,7 @@ private static void checkNotPathIdentifier(Identifier identifier, String method)
   }
 
   private Identifier namespaceToIdentifier(String[] namespace) {
+    assert namespace.length > 0;

Review comment:
       We don't use assertions. If this is worth checking, then use a Precondition to create a readable error message.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org