You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geronimo.apache.org by "Forrest Xia (Commented) (JIRA)" <ji...@apache.org> on 2012/03/26 07:24:43 UTC

[jira] [Commented] (GERONIMO-6296) Add a test case to validate ConnectorGBean way is still deployable via application deployment

    [ https://issues.apache.org/jira/browse/GERONIMO-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238108#comment-13238108 ] 

Forrest Xia commented on GERONIMO-6296:
---------------------------------------

xiezhi,

Thank you for providing this patch, it looks good, but before committing it, can you make these changes?
1. Refractor the ClassViewerServlet.java and use o.a.g as the package name
2. Add the ASF v2.0 license header to all files included in the patch. You can use "mvn rat:check" to do a check.

Thanks again for your contribution!

Forrest
                
> Add a test case to validate ConnectorGBean way is still deployable via application deployment
> ---------------------------------------------------------------------------------------------
>
>                 Key: GERONIMO-6296
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-6296
>             Project: Geronimo
>          Issue Type: Task
>      Security Level: public(Regular issues) 
>          Components: testsuite
>            Reporter: Forrest Xia
>            Assignee: xiezhi
>            Priority: Minor
>         Attachments: testcaseForconnectorByGBean.patch
>
>
> We need a test case to validate the GBean way defining the Tomcat Connector is still valid when deploying an application.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira