You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by sl...@apache.org on 2009/04/04 21:02:30 UTC
svn commit: r761986 - in /myfaces/core/branches/2_0_0:
api/src/main/java/javax/faces/component/
api/src/main/java/javax/faces/render/
api/src/main/java/javax/faces/view/facelets/
impl/src/main/java/org/apache/myfaces/context/ impl/src/main/java/org/apa...
Author: slessard
Date: Sat Apr 4 19:02:30 2009
New Revision: 761986
URL: http://svn.apache.org/viewvc?rev=761986&view=rev
Log:
Fixed some TODO usages.
Modified:
myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/component/UIViewParameter.java
myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/component/UIViewRoot.java
myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/render/ResponseStateManager.java
myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/view/facelets/FaceletContext.java
myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/context/ExceptionHandlerImpl.java
myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/view/ViewDeclarationLanguageBase.java
Modified: myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/component/UIViewParameter.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/component/UIViewParameter.java?rev=761986&r1=761985&r2=761986&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/component/UIViewParameter.java (original)
+++ myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/component/UIViewParameter.java Sat Apr 4 19:02:30 2009
@@ -74,14 +74,14 @@
public String getStringValue(FacesContext context)
{
- // TODO: IMPLEMENT
+ // TODO: IMPLEMENT HERE
return null;
}
public String getStringValueFromModel(FacesContext context) throws ConverterException
{
- // TODO: IMPLEMENT
+ // TODO: IMPLEMENT HERE
return null;
}
@@ -101,7 +101,7 @@
@Override
public void processValidators(FacesContext context)
{
- // TODO: IMPLEMENT
+ // TODO: IMPLEMENT HERE
}
@Override
@@ -132,7 +132,7 @@
{
super.updateModel(context);
- // TODO: IMPLEMENT
+ // TODO: IMPLEMENT HERE
}
@Override
Modified: myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/component/UIViewRoot.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/component/UIViewRoot.java?rev=761986&r1=761985&r2=761986&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/component/UIViewRoot.java (original)
+++ myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/component/UIViewRoot.java Sat Apr 4 19:02:30 2009
@@ -140,7 +140,7 @@
List<UIComponent> componentResources = getComponentResources(context, target);
// Add the component resource to the list
- // TODO: Validate if we should check for duplicates, spec don't say anything about it
+ // TODO: VALIDATE if we should check for duplicates, spec don't say anything about it
componentResources.add(componentResource);
}
Modified: myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/render/ResponseStateManager.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/render/ResponseStateManager.java?rev=761986&r1=761985&r2=761986&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/render/ResponseStateManager.java (original)
+++ myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/render/ResponseStateManager.java Sat Apr 4 19:02:30 2009
@@ -90,7 +90,7 @@
*/
public String getViewState(FacesContext context, Object state)
{
- // TODO: JSF 2.0
+ // TODO: IMPLEMENT HERE
return null;
}
Modified: myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/view/facelets/FaceletContext.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/view/facelets/FaceletContext.java?rev=761986&r1=761985&r2=761986&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/view/facelets/FaceletContext.java (original)
+++ myfaces/core/branches/2_0_0/api/src/main/java/javax/faces/view/facelets/FaceletContext.java Sat Apr 4 19:02:30 2009
@@ -42,7 +42,7 @@
*/
public abstract class FaceletContext extends ELContext
{
- // TODO: Report this aberration to the EG
+ // TODO: REPORT this aberration to the EG
public static final String FACELET_CONTEXT_KEY = "com.sun.faces.facelets.FACELET_CONTEXT";
/**
Modified: myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/context/ExceptionHandlerImpl.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/context/ExceptionHandlerImpl.java?rev=761986&r1=761985&r2=761986&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/context/ExceptionHandlerImpl.java (original)
+++ myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/context/ExceptionHandlerImpl.java Sat Apr 4 19:02:30 2009
@@ -182,8 +182,8 @@
protected Throwable wrap(Throwable exception)
{
- // TODO: This method should be abstract and implemented by a Portlet or Servlet version instance
- // wrapping to either ServletException or PortletException
+ // TODO: REPORT This method should be abstract and implemented by a Portlet or Servlet version
+ // instance wrapping to either ServletException or PortletException
return exception;
}
Modified: myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/view/ViewDeclarationLanguageBase.java
URL: http://svn.apache.org/viewvc/myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/view/ViewDeclarationLanguageBase.java?rev=761986&r1=761985&r2=761986&view=diff
==============================================================================
--- myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/view/ViewDeclarationLanguageBase.java (original)
+++ myfaces/core/branches/2_0_0/impl/src/main/java/org/apache/myfaces/view/ViewDeclarationLanguageBase.java Sat Apr 4 19:02:30 2009
@@ -77,7 +77,7 @@
newViewRoot.setRenderKitId(oldViewRoot.getRenderKitId());
}
- // TODO: The spec is silent on the following line, but I feel bad if I don't set it
+ // TODO: VALIDATE - The spec is silent on the following line, but I feel bad if I don't set it
newViewRoot.setViewId(viewId);
return newViewRoot;
@@ -88,7 +88,7 @@
// send the response error code SC_NOT_FOUND with a suitable message to the client.
sendSourceNotFound(context, e.getMessage());
- // TODO: Spec is silent on the return value when an error was sent
+ // TODO: VALIDATE - Spec is silent on the return value when an error was sent
return null;
}
}