[GitHub] [kafka] C0urante commented on pull request #13467: KAFKA-14863: Hide plugins with invalid constructors during plugin discovery

["C0urante (via GitHub)" <gi...@apache.org>]

C0urante commented on PR #13467:
URL: https://github.com/apache/kafka/pull/13467#issuecomment-1570310534

   Hmm... I don't necessarily agree that parity between the plugin discovery mechanisms warrants degrading the behavior of one to match the other.
   
   I do agree that the new log messages about poorly-packaged plugins here are informative, so it would be nice to include those changes regardless of whether we opt to hide them from the REST API. We could even include those messages in REST API errors when users try to use poorly-packaged plugins.
   
   It's also valid to emit these kinds of warning messages in the migration script, which should give users plenty of context about why a connector that appeared visible with plugin scanning discovery would no longer be visible with service loading discovery.
   
   Finally, while it may be a poor experience for users to see that a plugin has disappeared after migrating to service loading, this change doesn't actually prevent that experience, it only changes when it takes place. Instead of seeing plugins disappear after a migration, they'll see it whenever they perform an upgrade of their Connect cluster. Good logging by the migration script about invalid plugins being skipped is more likely to be noticed by users than worker startup logs (which tend to be quite verbose and are frequently only consulted after something has already broken, oftentimes as a last resort).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org