You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/17 00:20:19 UTC

[GitHub] [superset] junlincc opened a new issue #15751: [chord diagram]missing tooltip on chart when hovering/clicking

junlincc opened a new issue #15751:
URL: https://github.com/apache/superset/issues/15751


   Current Behavior: 
   https://user-images.githubusercontent.com/67837651/126019444-18e4678c-30e4-463e-aad7-4cfd85e3e354.mov
   
   Expected Behavior:
   https://docs.preset.io/docs/chord-diagram 
   
   @kgabryje thanks for spotting. 
   @xiezhongfu please work on this after the gallery project 🙏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kgabryje commented on issue #15751: [chord diagram]missing tooltip on chart when hovering/clicking

Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #15751:
URL: https://github.com/apache/superset/issues/15751#issuecomment-885517347


   @geido @rosemarie-chiu Yes, that was the case - I expected the tooltip to appear either on click or immediately on hover rather than 2 seconds later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #15751: [chord diagram]missing tooltip on chart when hovering/clicking

Posted by GitBox <gi...@apache.org>.
geido commented on issue #15751:
URL: https://github.com/apache/superset/issues/15751#issuecomment-885633057


   I think we can close this one as there is no actual bug


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] rosemarie-chiu commented on issue #15751: [chord diagram]missing tooltip on chart when hovering/clicking

Posted by GitBox <gi...@apache.org>.
rosemarie-chiu commented on issue #15751:
URL: https://github.com/apache/superset/issues/15751#issuecomment-885466129


   I do see tooltips on latest master. But I think it takes too long to show. Have to be very patient and stick mouse over there for like 2 secs.
   
   https://user-images.githubusercontent.com/52086618/126752811-87733ce6-aee9-4c85-bfe0-b04d8d16c31d.mp4
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #15751: [chord diagram]missing tooltip on chart when hovering/clicking

Posted by GitBox <gi...@apache.org>.
geido commented on issue #15751:
URL: https://github.com/apache/superset/issues/15751#issuecomment-885499918


   @rosemarie-chiu I believe this is a very resource intensive chart. Not sure if improving the performance should be in scope for the bug bashing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #15751: [chord diagram]missing tooltip on chart when hovering/clicking

Posted by GitBox <gi...@apache.org>.
geido commented on issue #15751:
URL: https://github.com/apache/superset/issues/15751#issuecomment-884135186


   Hello @junlincc. I don't see this issue in master. It appears that the tooltips are appearing on hover. The experience looks ok compared to this video https://docs.preset.io/docs/chord-diagram. Let me know what do you think. CC @rosemarie-chiu @jinghua-qa
   
   <img width="1680" alt="Screen Shot 2021-07-21 at 13 57 07" src="https://user-images.githubusercontent.com/60598000/126485165-a304bd0e-c15d-4f37-b80f-c0d65c3e2d27.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kgabryje commented on issue #15751: [chord diagram]missing tooltip on chart when hovering/clicking

Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #15751:
URL: https://github.com/apache/superset/issues/15751#issuecomment-884143689


   That's strange. For me they don't show up at all. I tested in Chrome and Safari, private mode and with different settings of the chart.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido closed issue #15751: [chord diagram]missing tooltip on chart when hovering/clicking

Posted by GitBox <gi...@apache.org>.
geido closed issue #15751:
URL: https://github.com/apache/superset/issues/15751


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido edited a comment on issue #15751: [chord diagram]missing tooltip on chart when hovering/clicking

Posted by GitBox <gi...@apache.org>.
geido edited a comment on issue #15751:
URL: https://github.com/apache/superset/issues/15751#issuecomment-884135186


   Hello @junlincc. I don't see this issue in master. It appears that the tooltips are appearing on hover. As for the click, it appears that clicking or pressing any key will make the tooltip fade, however, this seems to be the standard behavior. The experience looks good compared to this video https://docs.preset.io/docs/chord-diagram. CC @rosemarie-chiu @jinghua-qa
   
   <img width="1680" alt="Screen Shot 2021-07-21 at 13 57 07" src="https://user-images.githubusercontent.com/60598000/126485165-a304bd0e-c15d-4f37-b80f-c0d65c3e2d27.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] geido commented on issue #15751: [chord diagram]missing tooltip on chart when hovering/clicking

Posted by GitBox <gi...@apache.org>.
geido commented on issue #15751:
URL: https://github.com/apache/superset/issues/15751#issuecomment-885058255


   Tested again @kgabryje on the latest master. It appears to me. Are you giving it enough time to show up? It takes a bit to show fade in when hovering.
    
   <img width="1680" alt="Screen Shot 2021-07-22 at 18 41 57" src="https://user-images.githubusercontent.com/60598000/126676663-21dc4679-37fb-4ff7-82f3-fa7c3d8ac831.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org