You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/11/23 00:19:20 UTC
[GitHub] [tvm] tqchen opened a new issue #9551: [UX] TensorIR jupyter error message misuse
tqchen opened a new issue #9551:
URL: https://github.com/apache/tvm/issues/9551
Some lessons when trying out TensorIR on a jupyter session due to mis-use
- When passing different types(list of loops) to the split API, type checking error message is not as clear, consider do checking and raise error on python side.
https://gist.github.com/tqchen/01915c90334dbc2699971afe40dd2996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on issue #9551: [UX] Improve TensorIR jupyter misuse error message improvement suggestions
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on issue #9551:
URL: https://github.com/apache/tvm/issues/9551#issuecomment-976040385
UX issue should be treated as a bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on issue #9551: [UX] Improve TensorIR jupyter misuse error message improvement suggestions
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #9551:
URL: https://github.com/apache/tvm/issues/9551#issuecomment-976707713
Updated note on the c++ stacktrace side. The main annoying part are the expanded macro dispatchers in the FFI boundary that does not provide additional information.
So one solution is to update the trace normalizer to simplify and skip some of the less informative traces(e.g. unpackcall_dispatcher) but keep the rest of the useful traces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on issue #9551: [UX] Improve TensorIR jupyter misuse error message improvement suggestions
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on issue #9551:
URL: https://github.com/apache/tvm/issues/9551#issuecomment-976044432
Is it possible to turn off the stacktrace? It doesn't look useful in jupyter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on issue #9551: [UX] Improve TensorIR jupyter misuse error message improvement suggestions
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #9551:
URL: https://github.com/apache/tvm/issues/9551#issuecomment-976707713
Updated note on the c++ stacktrace side. The main annoying part are the expanded macro dispatchers in the FFI boundary that does not provide additional information.
So one solution is to update the trace normalizer to simplify and trim some of the less informative traces(e.g. unpackcall_dispatcher) but keep the rest of the useful traces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on issue #9551: [UX] Improve TensorIR jupyter misuse error message improvement suggestions
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #9551:
URL: https://github.com/apache/tvm/issues/9551#issuecomment-976047288
Let us check on the pythn side for the first one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on issue #9551: [UX] Improve TensorIR jupyter misuse error message improvement suggestions
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on issue #9551:
URL: https://github.com/apache/tvm/issues/9551#issuecomment-976043679
The second issue is easier to fix: rewrite the error message.
The first issue is more profound: it comes from the type checking in packed function interface. One workaround is to check the input types on python side for each API. However I don't know better any general approaches to do so. On the other hand, if `get_loops` returns a list containing only one element, we can sugar it out; not sure if it's good design though because it sacrifices consistency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen edited a comment on issue #9551: [UX] Improve TensorIR jupyter misuse error message improvement suggestions
Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on issue #9551:
URL: https://github.com/apache/tvm/issues/9551#issuecomment-976047288
Let us check on the python side for the first one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on issue #9551: [UX] Improve TensorIR jupyter misuse error message improvement suggestions
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on issue #9551:
URL: https://github.com/apache/tvm/issues/9551#issuecomment-976820847
@tqchen The dispatcher can be completely avoided by using other metaprogramming tricks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen closed issue #9551: [UX] Improve TensorIR jupyter misuse error message improvement suggestions
Posted by GitBox <gi...@apache.org>.
tqchen closed issue #9551:
URL: https://github.com/apache/tvm/issues/9551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org